fix(project-tree): search for product & project trees #32297
Conversation
…ropdown for only project/recent
|
Size Change: -3.19 kB (-0.09%) Total Size: 3.65 MB
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances search functionality across product and project trees, adding search capability to the product tree and improving path-based searches to handle slashes correctly.
- Added
searchResultsselector infrontend/src/layout/panel-layout/ProductTree/productTreeLogic.tsxto enable product tree searching - Modified
_apply_search_to_querysetinposthog/api/file_system.pyto split path tokens on '/' for better path-based searching - Moved tree-specific logic from
projectTreeLogicinto separateproductTreeLogicandgameTreeLogicfor better code organization - Added conditional rendering in
ProductTree.tsxto switch betweensearchResultsandproductTreeItemsbased on search term - Relocated
treeItemsCombinedfromprojectTreeLogictoshortcutsLogicfor improved separation of concerns
9 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| values: [featureFlagLogic, ['featureFlags'], projectTreeLogic, ['folderStates', 'users']], | ||
| actions: [], |
There was a problem hiding this comment.
style: No actions defined but connected to projectTreeLogic - consider if any actions need to be shared between trees
| (s) => [s.searchTerm, s.productTreeItems], | ||
| (searchTerm, productTreeItems): TreeDataItem[] => { | ||
| return productTreeItems.filter((item) => item.name.toLowerCase().includes(searchTerm.toLowerCase())) | ||
| }, |
There was a problem hiding this comment.
logic: Search implementation doesn't handle the slash-separated search terms mentioned in the PR description. Consider splitting searchTerm on '/' and matching each part independently to match the PR's stated goals.
There was a problem hiding this comment.
no, this code is for Products not Project (which is described in PR)
[waiting for this PR to merge, so i can rebase and clear stacked commits]
Problem
go/revenue(searchinggo revenuerevenue goworked though)ProductTreeproblem: searching products
problem: Searching
go/revenueChanges
/and searches for each part (regardless of order)ProductTreechanges: searching products
changes: Searching
go/revenueHow did you test this code?
Manually