Skip to content

fix(quick start): Send user to install screen when clicking on ingest first event #32286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lshaowei18
Copy link

Problem

Related issue: #32032

The behavior for /onboarding/product_analytics seems to be that it will remember the user's last visited step.

When a user first signs up for posthog, they are very likely to complete all the steps, ending at the invite_teammates step.

As a result, when they are routed to /onboarding/product_analytics, they will see the invite_teammates step.

Changes

  • Specify the exact step that makes the most sense when routing, which is install.

Does this work well for both Cloud and self-hosted?

I think it shouldn't have an impact.

How did you test this code?

Still trying to setup my local, so unable to test for now. If there are other ways to test it, please let me know and i will do the testing!

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes a routing issue in the onboarding flow where clicking 'Ingest your first event' incorrectly directed users to the invite teammates screen instead of the installation step.

  • Modified frontend/src/layout/navigation-3000/sidepanel/panels/activation/activationLogic.tsx to route to OnboardingStepKey.INSTALL when the ingest event task is clicked
  • The fix ensures new users are properly guided to the installation instructions when starting their PostHog journey
  • The change is minimal and focused, only affecting the routing behavior for this specific onboarding task
  • The solution aligns with the expected user flow, improving the initial onboarding experience

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant