Abstract away from just about everything #136
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaMatrix
force-pushed
the
dev/abstract-everything
branch
from
bf1527f
to
22cc032
Compare
…ile data packets to client
…MIN is no longer 0
# Conflicts: # mc/1.12.2-forge/build.gradle # settings.gradle
…promoted to a batch also do some internal refactors, and use lists in a lot of places where they weren't being used previously
also replace supportsLowResolution() with canGenerate(POS) in rough generator api
…les need to be marked as dirty the previous code was just using up(), which wouldn't have necessarily resulted in correct behavior
apparently i spoke too soon, and the offset is still necessary to avoid seams
this is to prepare for moving them back onto the heap
also deleted DirectLongStack, which has been un-used for months
also fixed a bug in SimpleList and deleted 1.12.2-forge's AsyncCacheNBTBase, which is unused
unit tests were failing on jenkins due to lack of memory, 1000000 points were probably a bit excessive anyway coordinate limits were one too high on each axis, although i've had to keep them high on voxel mode's Y axis for now because of the way that tiles aren't perfectly aligned to anything. this will be resolved once voxel tiles actually contain voxels rather than a weird voxely-mesh thing. sky light levels are supposed to be full above the build limit, so i've fixed that
this will avoid any future library conflicts
this avoids polluting the gradle classpath with a bunch of plugins which aren't required by all subprojects
…urces this ensures that we're referring to the correct texture ID when changing resource packs
rather than (quite badly) guessing the size of the OS send window, i've turned it into a system which relies on platform-specific methods to implement flow control. currently, this is only implemented for the following: - local (singleplayer) connections, which use no flow control at all - servers using Epoll (Linux), where Netty exposes an interface to set TCP_NOTSENT_LOWAT on the underlying native socket to a low value, as described in https://blog.cloudflare.com/http-2-prioritization-with-nginx/ other connections currently have no optimizations, and will "flow control" comparatively poorly by simply sending packets until the OS send window fills up. however, this isn't a priority, as the only two platforms in question are Windows and OSX, neither of which are commonly used for hosting servers - likely the only time servers will be run on these platforms is for LAN worlds, where flow control will be less important anyway thanks to a (presumably) fast LAN.
…ead has handled all packets
note to self: it helps if you run your code after you change it. i really need to figure out how to run integration tests on the entire game...
derp... how did i miss this?
lmao i never ended up using this
In all honesty, I should probably re-implement the off-heap stuff in native code - this is horrifically ugly in Java.
This prevents tons of unnecessary disk writes when toggling debug settings back and forth.
This makes NoFutureScheduler go through BlockingSupport when polling the work queue, so that interrupts actually get sent and are handled immediately.
We no longer distinguish between add/modify/remove notifications, which makes the code quite a bit easier to work with. Also, it now supports bulk notifications (although there aren't yet any optimized implementations of this yet), and it uses the new ListenerList infrastructure for (theoretically) improved performance!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a huge PR (which, in retrospect, probably should have been broken up into multiple smaller PRs). In combination with #117, it makes the vast majority of the codebase be able to operate entirely independently of the Minecraft version being used.
Additional major changes include:
T_SHIFTand related constants are now toHeightmapConstants/VoxelConstantsFEventBus, which uses a familiar annotation-based event subscription system. It supports a few additional features not commonly found in other event buses, such as the ability to weakly reference a registered handler object, and generic parameter matching.@DebugOnlyannotation is now gone. Debug statistics and related features are now available outside of debug mode.Logger, as are messages which appear in the client-side chat menu.With the exception of the
:glmodule and children (which are handled by #117), nearly everything is affected in some way.Known shortcomings: