Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .vscode, venv to .gitignore; remove .vscode from repository #198

Merged
merged 4 commits into from
May 8, 2024

Conversation

SylviaDu99
Copy link
Collaborator

@SylviaDu99 SylviaDu99 commented May 7, 2024

Changes Made

add .vscode, venv to .gitignore file; remove .vscode folder from repository

Related Issues

Fixes #72
Fixes #181

@anth-volk anth-volk self-requested a review May 7, 2024 12:42
@anth-volk
Copy link
Contributor

Thanks for your contribution @SylviaDu99! Would you mind updating the changelog by adding an entry to the changelog_entry.yaml file? The other PR currently open can serve as a template for how to do so.

@MaxGhenis
Copy link
Contributor

Please also edit the initial description to use the Fixes keyword, as to link the issues

@anth-volk
Copy link
Contributor

Don't worry, I'll deal with the merge conflict on this, since I created it with changes in #205 last night.

@anth-volk
Copy link
Contributor

Also, I took the liberty of editing your initial comment. It's not obvious, but you have to list each fix on a separate line.

Copy link
Contributor

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SylviaDu99! Looks great.

In the future, we recommend forking our repo, like you did, but contributing off of a feature branch, and keeping your fork's master up-to-date with ours. More info is available on the README of our app repo at https://www.github.com/PolicyEngine/policyengine-app

@anth-volk anth-volk merged commit ae69717 into PolicyEngine:master May 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .vscode to .gitignore and remove .vscode from repository Add venv to .gitignore
3 participants