Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Brunswick Spouse or Common-law partner amount #492

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

New Brunswick Spouse or Common-law partner amount #492

wants to merge 11 commits into from

Conversation

karenlilr
Copy link

Fixes #352

PavelMakarchuk
PavelMakarchuk requested changes Jun 22, 2024
View reviewed changes
...ers/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/base_amount.yaml Show resolved Hide resolved
...ers/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/base_amount.yaml Outdated Show resolved Hide resolved
...ters/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/income_cap.yaml Outdated Show resolved Hide resolved
...ters/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/income_cap.yaml Outdated Show resolved Hide resolved
...ters/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/income_cap.yaml Outdated Show resolved Hide resolved
...ers/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/base_amount.yaml Outdated Show resolved Hide resolved
...ers/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/base_amount.yaml Outdated Show resolved Hide resolved
...ters/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/income_cap.yaml Outdated Show resolved Hide resolved
...ters/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/income_cap.yaml Outdated Show resolved Hide resolved
PavelMakarchuk
PavelMakarchuk requested changes Jul 11, 2024
View reviewed changes
...redits/spouse_or_common_law_partner_amount/nb_spouse_and_common_law_partner_amount_credit.py Outdated Show resolved Hide resolved
...ers/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/base_amount.yaml Outdated Show resolved Hide resolved
...redits/spouse_or_common_law_partner_amount/nb_spouse_and_common_law_partner_amount_credit.py Outdated Show resolved Hide resolved
...redits/spouse_or_common_law_partner_amount/nb_spouse_and_common_law_partner_amount_credit.py Outdated Show resolved Hide resolved
...parameters/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/test.yaml
spouse_income: 10_000

- name: Ineligible spouse
period: 2022
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one period per test

...parameters/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/test.yaml Outdated Show resolved Hide resolved
...dits/spouse_or_common_law_partner_amount/nb_spouse_and_common_law_partner_amount_credit.yaml Outdated Show resolved Hide resolved
...redits/spouse_or_common_law_partner_amount/nb_spouse_and_common_law_partner_amount_credit.py Outdated Show resolved Hide resolved
...parameters/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/test.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this

PavelMakarchuk
PavelMakarchuk requested changes Jul 25, 2024
View reviewed changes
...nada/variables/gov/provinces/nb/tax/income/nb_spouse_and_common_law_partner_amount_credit.py Outdated Show resolved Hide resolved
...ests/gov/provinces/nb/tax/income/credits/nb_spouse_and_common_law_partner_amount_credit.yaml Show resolved Hide resolved
...parameters/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/test.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still delete this

...ers/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/base_amount.yaml Show resolved Hide resolved
PavelMakarchuk
PavelMakarchuk requested changes Jul 30, 2024
View reviewed changes
...ters/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/max_credit.yaml Outdated Show resolved Hide resolved
...ters/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/max_credit.yaml Outdated Show resolved Hide resolved
...ters/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/max_credit.yaml Outdated Show resolved Hide resolved
...ers/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/base_amount.yaml Outdated Show resolved Hide resolved
...nada/variables/gov/provinces/nb/tax/income/nb_spouse_and_common_law_partner_amount_credit.py Outdated Show resolved Hide resolved
...ests/gov/provinces/nb/tax/income/credits/nb_spouse_and_common_law_partner_amount_credit.yaml Outdated Show resolved Hide resolved
PavelMakarchuk
PavelMakarchuk requested changes Aug 2, 2024
View reviewed changes
...ers/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/base_amount.yaml Outdated Show resolved Hide resolved
...ters/gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/max_amount.yaml Outdated Show resolved Hide resolved
...nada/variables/gov/provinces/nb/tax/income/nb_spouse_and_common_law_partner_amount_credit.py Outdated Show resolved Hide resolved
...nada/variables/gov/provinces/nb/tax/income/nb_spouse_and_common_law_partner_amount_credit.py

def formula(household, period, parameters):
p = parameters(period).gov.provinces.nb.tax.income.credits.spouse_or_common_law_partner_amount

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

changelog_entry.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelMakarchuk PavelMakarchuk PavelMakarchuk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Brunswick Spouse or Common-law partner amount
2 participants
@karenlilr @PavelMakarchuk