Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quick search casing issue - v1 patch #347

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

EvilDrPurple
Copy link
Contributor

Fixes

Description

  • The quick search terms were previously case sensitive, causing some results to be excluded
  • Removes .title() function that was previously applied to the search terms
  • Changes the SQL query from LIKE to ILIKE (case-insensitive LIKE)
  • ILIKE is a PSQL keyword similar to using UPPER() or LOWER() for case insensitive matching in other SQL versions. Read more about it here: https://www.postgresql.org/docs/current/functions-matching.html#FUNCTIONS-LIKE

image
image

Testing

  • Checkout the branch
  • Setup testing environment like normal
  • Search using terms outlined in issue 346 and confirm the results are now returned properly

@EvilDrPurple EvilDrPurple linked an issue Jul 5, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@maxachis maxachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Approved!

@josh-chamberlain josh-chamberlain merged commit 54915a6 into main Jul 16, 2024
8 of 10 checks passed
@josh-chamberlain josh-chamberlain deleted the 346-v1-quicksearch-string-matching-bug branch July 16, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1 quicksearch string matching bug
3 participants