Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor security.py and add error message for insufficient permissions #310

Open
maxachis opened this issue May 29, 2024 · 0 comments
Open

Refactor security.py and add error message for insufficient permissions #310

maxachis opened this issue May 29, 2024 · 0 comments
Labels
enhancement New feature or request in_dev This is merged into the dev environment and waiting to be merged into main refactor Improve the code without changing the underlying logic

Comments

@maxachis
Copy link
Contributor

Both is_valid and api_required are fairly dense with if-conditionals whose logic it can be difficult to parse without digging deep into it. This could benefit from refactoring.

In addition, there is no error message for when a user does not have the correct permissions to perform an action. For additional clarity, we probably want to add this.
@maxachis maxachis added enhancement New feature or request refactor Improve the code without changing the underlying logic labels May 29, 2024
This was referenced Jun 3, 2024
Closed
Merged
@EvilDrPurple EvilDrPurple added the in_dev This is merged into the dev environment and waiting to be merged into main label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request in_dev This is merged into the dev environment and waiting to be merged into main refactor Improve the code without changing the underlying logic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxachis @EvilDrPurple