Mc issue 310 refactor security #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s if not provided. Add function to create API key in the database.
…tatus of API keys, session tokens, and access tokens in the security middleware module.
… handling API key validation and user roles.
…310_refactor_security # Conflicts: # tests/helper_functions.py
…dation and role checking.
Removed redundant NoAPIKeyError handling in security middleware to improve code readability and maintainability.🛠️
josh-chamberlain
approved these changes
Jun 6, 2024
|
Nice. Another thing you might have missed from the early days, that I would like to put in your head, is that we would probably be better off with |
@josh-chamberlain Got it. Is this worth making an issue about and/or addressing in v2? |
|
@maxachis we don't have plans for too many complex/deep privileged actions, so there's not much to do yet (I don't think) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
security.pyand add error message for insufficient permissions data-sources-app#310Description
is_validandapi_requiredto have more straightforward logic, utilize function extraction where possible, and replace magic numbers and magic strings with reusable constants and functions.middleware\test_security.py, providing 100% coverage.Testing
Performance
Docs