Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quick search not showing all results - v2 patch #43

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Fix quick search not showing all results - v2 patch #43

merged 1 commit into from
Jul 5, 2024

Conversation

EvilDrPurple
Copy link

Fixes

Description

  • Added two missing categories to pageData.js: Media Bulletins and Other
  • A new header Other is used for Other record types, Media Bulletins is grouped under Agency-published resources

image
image

Testing

  • Checkout the branch and setup testing environment like normal
  • Search for and confirm previously unshown data sources are now shown on the results page

maxachis
maxachis approved these changes Jul 5, 2024
View reviewed changes
Copy link

@maxachis maxachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@maxachis maxachis merged commit 856e43f into dev Jul 5, 2024
8 of 11 checks passed
@maxachis maxachis deleted the 348-quicksearch-bug branch July 5, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxachis maxachis maxachis approved these changes

@josh-chamberlain josh-chamberlain Awaiting requested review from josh-chamberlain josh-chamberlain is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@EvilDrPurple @maxachis