Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casing search issue - v2 patch #42

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Fix casing search issue - v2 patch #42

merged 1 commit into from
Jul 5, 2024

Conversation

EvilDrPurple
Copy link

@EvilDrPurple EvilDrPurple commented Jul 5, 2024

Fixes

Description

  • The quick search terms were previously case sensitive, causing some results to be excluded
  • Removes .title() function that was previously applied to the search terms
  • Changes the SQL query from LIKE to ILIKE (case-insensitive LIKE)
  • ILIKE is a PSQL keyword similar to using UPPER() or LOWER() for case insensitive matching in other SQL versions. Read more about it here: https://www.postgresql.org/docs/current/functions-matching.html#FUNCTIONS-LIKE

image
image

Testing

  • Checkout the branch
  • Setup testing environment like normal
  • Search using terms outlined in issue 346 and confirm the results are now returned properly

@maxachis
Copy link

maxachis commented Jul 5, 2024

@EvilDrPurple Accidentally merged this!

Functionally, I have no issue with this. However, because it's occurring at the same time as the database client updates, I'd like to request that this instead be a PR into the relevant database client code instead, so as to avoid painful code confusion later on.

In essence, this means either making this a PR into the mc_issue_337_create_database_client branch, or waiting until that's merged into dev and then recreating this PR for that.

@EvilDrPurple
Copy link
Author

@maxachis ah yeah I was actually thinking about that, I can probably just do the same and merge into the other branch real quick

@EvilDrPurple EvilDrPurple deleted the 346-quicksearch-bug branch July 5, 2024 19:43
@EvilDrPurple EvilDrPurple mentioned this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants