Replace status codes with HTTPStatus #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxachis
requested changes
Jun 19, 2024
There was a problem hiding this comment.
Add a glance, it looks good! But I also want to be sure that these changes don't cause any of the tests to fail. Using the instructions available, are you able to run these tests and confirm their functionality, or is there something missing (including potentially environment variables needed to run the tests.
I could check out this branch myself and verify, but it's also useful for me to know if the tests I've designed are accessible and useable by other developers.
|
@maxachis tested and all passed! |
@EvilDrPurple Excellent! Next on the agenda is setting up the system to run these tests automatically on particular pull requests, but this is a good start! Approved! |
maxachis
deleted the
319-replace-hardcoded-http-status-values-with-httphttpstatus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
http.HTTPStatusdata-sources-app#319Description