Make the dependency of "outofcore" on "visualization" optional. #6254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose the following patch, to make the
outofcore
component not depend on thevisualization
component, because that brings in a pretty large dependency chain via VTK.I noticed that
outofcore
needs only a single method fromvisualization
, which is this overload ofqueryFrustum
.I'm not sure if my approach to make this dependency optional in CMake is correct. But it seems to work fine on my end.
What it does is:
visualization
is enabled, andoutofcore
is enabled, the latter will be built as normalvisualization
is disabled, butoutofcore
is enabled, the latter will be built without the method.