-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New Components - harpa_ai #17690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
New Components - harpa_ai #17690
Conversation
WalkthroughThis update introduces Harpa AI integration with three new action modules: "Run AI Command," "Search the Web," and "Scrape Web Page." It also adds utility functions, expands the app's property definitions and methods, and updates dependencies. The changes enable structured API interactions for automating web tasks, searching, and content extraction. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ActionModule
participant HarpaAIApp
participant HarpaAIAPI
User->>ActionModule: Trigger action (Run AI Command / Search / Scrape)
ActionModule->>HarpaAIApp: sendAction({ parameters })
HarpaAIApp->>HarpaAIAPI: POST /grid with parameters
HarpaAIAPI-->>HarpaAIApp: Response
HarpaAIApp-->>ActionModule: Response
ActionModule-->>User: Summary & response
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/harpa_ai/actions/scrape-web-page/scrape-web-page.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/harpa_ai/actions/run-ai-command/run-ai-command.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/harpa_ai/actions/search-the-web/search-the-web.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (5)
components/harpa_ai/actions/run-ai-command/run-ai-command.mjs (1)
23-28
: Consider adding input validation for the inputs array.The
inputs
prop accepts a string array but lacks validation. Invalid input could cause issues when parsed byparseObject
.Consider adding validation:
inputs: { type: "string[]", label: "Inputs", description: "An array of Strings, each one passed down into command in place of the user input. Inputs are used to bypass waiting for the user input in multi-step commands. For example [ \"REPORT\", \"DONE\" ] for the Summary command.", optional: true, + validate: (value) => { + if (value && !Array.isArray(value)) { + throw new Error("Inputs must be an array"); + } + return true; + }, },components/harpa_ai/actions/scrape-web-page/scrape-web-page.mjs (1)
17-22
: Consider adding validation for the grab selectors array.Similar to the inputs array in
run-ai-command
, thegrab
prop could benefit from input validation to ensure it's a proper array of CSS selectors.Consider adding validation:
grab: { type: "string[]", label: "Grab", description: "An array of HTML Element selectors to scrape from the page. Refer to the [Scraping Web Page Elements and Data](https://harpa.ai/grid/grid-rest-api-reference#scraping-web-page-elements-and-data) section for more details.", optional: true, + validate: (value) => { + if (value && !Array.isArray(value)) { + throw new Error("Grab must be an array of CSS selectors"); + } + return true; + }, },components/harpa_ai/actions/search-the-web/search-the-web.mjs (1)
11-15
: Consider adding validation for the query parameter.The query parameter is required but lacks validation for empty strings or overly long queries that might cause API issues.
Consider adding validation:
query: { type: "string", label: "Query", description: "The search term or a query string to search for. Supports search parameters like **site:example.com** or **intitle:keyword**.", + validate: (value) => { + if (!value || value.trim().length === 0) { + throw new Error("Query cannot be empty"); + } + if (value.length > 1000) { + throw new Error("Query is too long"); + } + return true; + }, },components/harpa_ai/harpa_ai.app.mjs (2)
13-17
: Consider using integer type for timeout property.The timeout property should use
integer
type instead ofstring
since it represents a duration value. This provides better type safety and validation.- timeout: { - type: "string", - label: "Timeout", - description: "Synchronous action execution timeout", - optional: true, - }, + timeout: { + type: "integer", + label: "Timeout", + description: "Synchronous action execution timeout (in seconds)", + optional: true, + min: 1, + },
35-38
: Fix header casing for Content-Type.The Content-Type header should use proper casing according to HTTP standards.
- "Content-type": "application/json", + "Content-Type": "application/json",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (6)
components/harpa_ai/actions/run-ai-command/run-ai-command.mjs
(1 hunks)components/harpa_ai/actions/scrape-web-page/scrape-web-page.mjs
(1 hunks)components/harpa_ai/actions/search-the-web/search-the-web.mjs
(1 hunks)components/harpa_ai/common/utils.mjs
(1 hunks)components/harpa_ai/harpa_ai.app.mjs
(1 hunks)components/harpa_ai/package.json
(2 hunks)
🧰 Additional context used
🧠 Learnings (4)
components/harpa_ai/package.json (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
components/harpa_ai/actions/run-ai-command/run-ai-command.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
components/harpa_ai/actions/scrape-web-page/scrape-web-page.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
components/harpa_ai/harpa_ai.app.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
Learnt from: js07
PR: PipedreamHQ/pipedream#17375
File: components/zerobounce/actions/get-validation-results-file/get-validation-results-file.mjs:23-27
Timestamp: 2025-07-01T17:07:48.193Z
Learning: For "dir" props in Pipedream components, whether to mark them as optional depends on the action's file I/O behavior - if an action always writes files as output, the "dir" prop should not be marked as optional.
🧬 Code Graph Analysis (2)
components/harpa_ai/actions/run-ai-command/run-ai-command.mjs (3)
components/harpa_ai/actions/search-the-web/search-the-web.mjs (1)
response
(36-45)components/harpa_ai/actions/scrape-web-page/scrape-web-page.mjs (1)
response
(43-53)components/harpa_ai/common/utils.mjs (2)
parseObject
(1-25)parseObject
(1-25)
components/harpa_ai/actions/search-the-web/search-the-web.mjs (2)
components/harpa_ai/actions/scrape-web-page/scrape-web-page.mjs (1)
response
(43-53)components/harpa_ai/actions/run-ai-command/run-ai-command.mjs (1)
response
(61-74)
🔇 Additional comments (8)
components/harpa_ai/package.json (2)
3-3
: Appropriate version bump for new features.The version update from "0.0.1" to "0.1.0" correctly reflects the addition of new action components and functionality.
15-17
: Correct dependency addition.The addition of
@pipedream/platform
as a dependency is appropriate for the new HTTP request functionality used in the action components.components/harpa_ai/actions/run-ai-command/run-ai-command.mjs (1)
60-77
: Well-structured action implementation.The action follows Pipedream best practices with proper async/await handling, consistent parameter passing, and appropriate summary message formatting.
components/harpa_ai/actions/scrape-web-page/scrape-web-page.mjs (1)
42-56
: Consistent action implementation.The action follows the same pattern as other Harpa AI actions with proper use of
sendAction
,parseObject
, and summary export.components/harpa_ai/actions/search-the-web/search-the-web.mjs (1)
35-48
: Clean and consistent implementation.The action follows the established pattern with proper use of
sendAction
and maintains consistency with other Harpa AI actions.components/harpa_ai/harpa_ai.app.mjs (3)
1-1
: LGTM!The import statement correctly uses the Pipedream platform axios module.
27-29
: LGTM!The base URL method is correctly implemented and follows standard Pipedream patterns.
42-48
: LGTM!The sendAction method is well-implemented, correctly using the private _makeRequest method with appropriate defaults and customization options.
Resolves #17565
Summary by CodeRabbit
New Features
Improvements
Chores