Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to polling triggers if user is not a Linear admin #14920

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented Dec 10, 2024

Resolves #14904

Summary by CodeRabbit

  • New Features

    • Updated version of the @pipedream/linear package.
    • Added new methods for retrieving resources in several components.
    • Introduced polling functionality to manage issue status updates more efficiently.
  • Bug Fixes

    • Improved clarity in documentation references across multiple components.
  • Documentation

    • Updated description fields to enhance clarity and consistency.
  • Chores

    • Incremented version numbers across various components.

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 4:19pm
pipedream-docs ⬜️ Ignored (Inspect) Dec 12, 2024 4:19pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Dec 12, 2024 4:19pm

Copy link
Contributor

coderabbitai bot commented Dec 10, 2024

Walkthrough

The pull request includes updates to several files within the components/linear and components/linear_app directories. Key changes involve incrementing version numbers in multiple package.json files and updating the description fields in various modules to improve documentation clarity. Additionally, new methods for retrieving resources have been introduced in several modules, enhancing their functionality. The webhook component has undergone significant modifications to its control flow, allowing for fallback to polling triggers when a user lacks admin permissions.

Changes

File Change Summary
components/linear/package.json Updated version from 0.5.6 to 0.5.7.
components/linear/sources/comment-created-instant/comment-created-instant.mjs Updated description and version from 0.1.6 to 0.1.7.
components/linear/sources/issue-created-instant/issue-created-instant.mjs Updated description and version from 0.3.6 to 0.3.7.
components/linear/sources/issue-updated-instant/issue-updated-instant.mjs Updated description and version from 0.3.6 to 0.3.7.
components/linear/sources/new-issue-status-updated/new-issue-status-updated.mjs Updated description, added methods, and version from 0.1.6 to 0.1.7.
components/linear_app/package.json Updated version from 0.5.6 to 0.5.7.
components/linear_app/sources/comment-created-instant/comment-created-instant.mjs Updated description, added getResource(comment) method, and version from 0.1.6 to 0.1.7.
components/linear_app/sources/common/webhook.mjs Significant changes to control flow, added emitPolledResources() and getResource() methods.
components/linear_app/sources/issue-created-instant/issue-created-instant.mjs Updated description, added getResource(issue) method.
components/linear_app/sources/issue-updated-instant/issue-updated-instant.mjs Updated description, added getResource(issue) method, and modified getMetadata(resource) method.

Assessment against linked issues

Objective Addressed Explanation
Fall back to polling triggers if user is not a Linear admin (#14904)
Implement info alert prop for non-admin users (#14904) No alert prop has been introduced in the changes.

Possibly related PRs

Suggested labels

ai-assisted

Poem

🐰 In the code where bunnies hop,
Versions change, they never stop.
Descriptions clear, like morning dew,
New methods added, oh what a view!
Polling for triggers, a clever plan,
For every bunny, every fan! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b20ca13 and 7c52c8b.

📒 Files selected for processing (1)
  • components/linear_app/sources/issue-updated-instant/issue-updated-instant.mjs (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • components/linear_app/sources/issue-updated-instant/issue-updated-instant.mjs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

luancazarine
luancazarine previously approved these changes Dec 11, 2024
Copy link
Collaborator

@luancazarine luancazarine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michelle0927, LGTM! Ready for QA!

@michelle0927
Copy link
Collaborator Author

/approve

@michelle0927 michelle0927 merged commit a68048d into master Dec 16, 2024
11 checks passed
@michelle0927 michelle0927 deleted the issue-14904 branch December 16, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Fall back to polling triggers if user is not a Linear admin
2 participants