Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed PintaCore references from SimpleEffectDialog #1248

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Removed PintaCore references from SimpleEffectDialog #1248

merged 5 commits into from
Feb 5, 2025

Conversation

Lehonti
Copy link
Contributor

@Lehonti Lehonti commented Feb 4, 2025 •
edited
Loading

This required changing all effects that use SimpleEffectDialog. In many cases, I changed the choice of overloaded Render method to the simpler one.

@Lehonti Lehonti marked this pull request as draft February 4, 2025 02:02
@Lehonti
Copy link
Contributor Author

Lehonti commented Feb 4, 2025 •
edited
Loading

Marked as draft because an exception is thrown when using the Vignette effect Update: Fixed. See below

@Lehonti Lehonti marked this pull request as ready for review February 4, 2025 02:14
@Lehonti
Copy link
Contributor Author

Lehonti commented Feb 4, 2025

Re-opened because null reference issue was solved

@cameronwhite cameronwhite merged commit 6d3933e into PintaProject:master Feb 5, 2025
6 checks passed
@Lehonti Lehonti deleted the improvement3 branch February 5, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lehonti @cameronwhite