Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing typed_data import #656

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix missing typed_data import #656

wants to merge 5 commits into from

Conversation

rfuerst87
Copy link

Fixes #649 and probably also #653.

@rfuerst87
Copy link
Author

No idea why Ble Workflow is failing. Quality checks run just fine on my machine. Unfortunately I do not have access to codemagic logs. Could the checked in pubspec.lock files cause problems? See #652 and #655.

@rfuerst87
Copy link
Author

rfuerst87 commented Dec 14, 2022 •
edited
Loading

Ok, turns out flutter 3.3.0 explicitly exports Uint8List from dart:typed_data in package:flutter/foundation.dart. I'm not really sure whether the compatibility break was intentional or not. As you removed the imports I did set minimum requirements for flutter to 3.3.0. See this PR from flutter: flutter/flutter#105648

Another option would be to add the imports again and advise the linter to ignore unnecessary imports using // ignore: unnecessary_import. Anyway, at some point you probably want to get rid of the imports.

Let me know what you prefer. I'll update the PR accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't build with 5.0.3: The getter 'Uint8List' isn't defined for the class 'ProtobufConverterImpl'.
1 participant
@rfuerst87