Add -rpath when compiling XS modules on macOS #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please change the commit title to something that actually describe what it does? |
hakonhagland
changed the title
|
@Leont I have updated the title to something more descriptive. |
|
The important thing to fix is the subject of the actual commit, not the title of the PR. |
This fixes issue Perl-Toolchain-Gang#402 This change fixes issue Perl-Toolchain-Gang#402 on my machine.
hakonhagland
force-pushed
the
mac_rpath
branch
from
dde55f2 to
4eb1d19
Compare
|
@haarg I have update the commit message with the same title |
mohawk2
approved these changes
Sep 24, 2021
|
@hakonhagland Could you add a test that breaks on MacOS without this change? That way we can permanently capture the benefit. |
added 2 commits
October 6, 2021 14:52
Added a new test case that tests a special case for the generation of XS modules on OS darwin. More specifically, it tests if we are able to compile an XS module which refers to another shared library in a non-standard location such that we can load the XS module from a perl script without having to set the DYLD_LIBRARY_PATH environment variable. See PR Perl-Toolchain-Gang#403 and issue Perl-Toolchain-Gang#402.
Removed some debugging statements from the test code.
|
@mohawk2 I have added a test case, see the new commits. |
Looks good. I've enabled the CI to run. |
bingos
pushed a commit
that referenced
this pull request
Nov 3, 2021
Added a new test case that tests a special case for the generation of XS modules on OS darwin. More specifically, it tests if we are able to compile an XS module which refers to another shared library in a non-standard location such that we can load the XS module from a perl script without having to set the DYLD_LIBRARY_PATH environment variable. See PR #403 and issue #402.
khwilliamson
pushed a commit
to khwilliamson/ExtUtils-MakeMaker
that referenced
this pull request
Dec 12, 2021
Added a new test case that tests a special case for the generation of XS modules on OS darwin. More specifically, it tests if we are able to compile an XS module which refers to another shared library in a non-standard location such that we can load the XS module from a perl script without having to set the DYLD_LIBRARY_PATH environment variable. See PR Perl-Toolchain-Gang#403 and issue Perl-Toolchain-Gang#402.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes issue #402 on my machine.