Holy crap auth works (#2099)

* Holy crap auth works

* Fix some usages of UserID instead of UserName

* Refactor preferences.

They be non-async now. Also faster.

* Rename DbContext.

* Guest username assignment.

* Fix saving of profiles.

* Don't store data for guests.

* Fix generating invalid random colors.

* Don't allow dumb garbage for char preferences.

* Bans.

* Lol forgot to fill out the command description.

* Connection log.

* Rename all the tables and columns to be snake_case.

* Re-do migrations.

* Fixing tests and warnings.

* Update submodule

Content.Client/GameTicking/ClientGameTicker.cs

@@ -28,7 +28,7 @@ public class ClientGameTicker : SharedGameTicker, IClientGameTicker
         [ViewVariables] public string ServerInfoBlob { get; private set; }
         [ViewVariables] public DateTime StartTime { get; private set; }
         [ViewVariables] public bool Paused { get; private set; }
-        [ViewVariables] public Dictionary<NetSessionId, PlayerStatus> Status { get; private set; }
+        [ViewVariables] public Dictionary<NetUserId, PlayerStatus> Status { get; private set; }
 
         public event Action InfoBlobUpdated;
         public event Action LobbyStatusUpdated;
@@ -52,7 +52,7 @@ public void Initialize()
             });
             _netManager.RegisterNetMessage<MsgTickerLateJoinStatus>(nameof(MsgTickerLateJoinStatus), LateJoinStatus);
 
-            Status = new Dictionary<NetSessionId, PlayerStatus>();
+            Status = new Dictionary<NetUserId, PlayerStatus>();
             _initialized = true;
         }
 

Content.Client/Interfaces/IClientGameTicker.cs

@@ -13,7 +13,7 @@ public interface IClientGameTicker
         bool DisallowedLateJoin { get; }
         DateTime StartTime { get; }
         bool Paused { get; }
-        Dictionary<NetSessionId, PlayerStatus> Status { get; }
+        Dictionary<NetUserId, PlayerStatus> Status { get; }
 
         void Initialize();
         event Action InfoBlobUpdated;

Content.Client/State/LobbyState.cs

@@ -220,10 +220,10 @@ private void UpdatePlayerList()
                 if (!_clientGameTicker.IsGameStarted)
                 {
                     var status = PlayerStatus.NotReady;
-                    if (session.SessionId == _playerManager.LocalPlayer.SessionId)
+                    if (session.UserId == _playerManager.LocalPlayer.UserId)
                         status = _clientGameTicker.AreWeReady ? PlayerStatus.Ready : PlayerStatus.NotReady;
                     else
-                        _clientGameTicker.Status.TryGetValue(session.SessionId, out status);
+                        _clientGameTicker.Status.TryGetValue(session.UserId, out status);
 
                     readyState = status switch
                     {

Content.Client/UserInterface/HumanoidProfileEditor.Random.cs

@@ -1,8 +1,10 @@
-using System.Linq;
+using System;
+using System.Linq;
 using Content.Shared.Preferences;
 using Content.Shared.Preferences.Appearance;
 using Content.Shared.Text;
 using Robust.Shared.Interfaces.Random;
+using Robust.Shared.Maths;
 using Robust.Shared.Random;
 
 namespace Content.Client.UserInterface
@@ -51,9 +53,9 @@ private void RandomizeAppearance()
 
             var newHairColor = _random.Pick(HairStyles.RealisticHairColors);
             newHairColor = newHairColor
-                .WithRed(newHairColor.R + _random.Next(-25, 25) / 100f)
-                .WithGreen(newHairColor.G + _random.Next(-25, 25) / 100f)
-                .WithBlue(newHairColor.B + _random.Next(-25, 25) / 100f);
+                .WithRed(RandomizeColor(newHairColor.R))
+                .WithGreen(RandomizeColor(newHairColor.G))
+                .WithBlue(RandomizeColor(newHairColor.B));
 
             Profile = Profile.WithCharacterAppearance(
                 Profile.Appearance
@@ -62,6 +64,11 @@ private void RandomizeAppearance()
                     .WithHairColor(newHairColor)
                     .WithFacialHairColor(newHairColor));
             UpdateHairPickers();
+
+            float RandomizeColor(float channel)
+            {
+                return MathHelper.Clamp01(channel + _random.Next(-25, 25) / 100f);
+            }
         }
     }
 }

Content.IntegrationTests/Tests/MindEntityDeletionTest.cs

@@ -37,7 +37,7 @@ public async Task TestDeleteVisiting()
                 playerEnt = entMgr.SpawnEntity(null, MapCoordinates.Nullspace);
                 visitEnt = entMgr.SpawnEntity(null, MapCoordinates.Nullspace);
 
-                mind = new Mind(player.SessionId);
+                mind = new Mind(player.UserId);
                 player.ContentData().Mind = mind;
 
                 mind.TransferTo(playerEnt);
@@ -81,7 +81,7 @@ public async Task TestGhostOnDelete()
 
                 playerEnt = entMgr.SpawnEntity(null, MapCoordinates.Nullspace);
 
-                mind = new Mind(player.SessionId);
+                mind = new Mind(player.UserId);
                 player.ContentData().Mind = mind;
 
                 mind.TransferTo(playerEnt);
@@ -130,7 +130,7 @@ public async Task TestGhostOnDeleteMap()
 
                 playerEnt = entMgr.SpawnEntity(null, grid.ToCoordinates());
 
-                mind = new Mind(player.SessionId);
+                mind = new Mind(player.UserId);
                 player.ContentData().Mind = mind;
 
                 mind.TransferTo(playerEnt);

Content.Server.Database/Content.Server.Database.csproj

@@ -21,4 +21,9 @@
     <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="3.1.4" />
   </ItemGroup>
 
+  <ItemGroup>
+    <Folder Include="Migrations\Postgres" />
+    <Folder Include="Migrations\Sqlite" />
+  </ItemGroup>
+
 </Project>