Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-components: Fix styles on disabled Button #133

Merged
merged 15 commits into from
Dec 12, 2023
Merged

react-components: Fix styles on disabled Button #133

merged 15 commits into from
Dec 12, 2023

Conversation

MykhailoPV
Copy link
Contributor

@MykhailoPV MykhailoPV commented Dec 5, 2023 •
edited
Loading

Difference in styles on disabled buttons and FAB components between mockup and lib-components

Fixed LM and DM:

  • variant === 'outlined'
  • variant === 'contained'
  • variant === 'text'
Screenshot 2023-12-06 at 18 12 15 Screenshot 2023-12-11 at 14 05 14 Screenshot 2023-12-11 at 14 09 52

@MykhailoPV MykhailoPV self-assigned this Dec 5, 2023
MarikTar
MarikTar requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@MarikTar MarikTar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix PR description and title

package.json Outdated Show resolved Hide resolved
packages/react-components/src/ButtonBase/button_base.tsx Outdated Show resolved Hide resolved
@MykhailoPV MykhailoPV changed the title react-components: Add DM styles on disabled button react-components: Fix DM styles on disabled Button Dec 6, 2023
@MykhailoPV MykhailoPV requested a review from MarikTar December 7, 2023 09:29
MarikTar
MarikTar requested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@MarikTar MarikTar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect color (outlined-disable):
mockup:
image

localhost:
image

@MykhailoPV MykhailoPV requested a review from MarikTar December 7, 2023 12:09
MarikTar
MarikTar previously approved these changes Dec 8, 2023
View reviewed changes
@MarikTar MarikTar added invalid This doesn't seem right and removed ready for review labels Dec 11, 2023
@MykhailoPV MykhailoPV changed the title react-components: Fix DM styles on disabled Button react-components: Fix styles on disabled Button Dec 11, 2023
@MykhailoPV MykhailoPV requested a review from MarikTar December 11, 2023 12:25
@MykhailoPV MykhailoPV added ready for review and removed invalid This doesn't seem right labels Dec 11, 2023
@donskov donskov merged commit 4451484 into main Dec 12, 2023
1 check passed
@donskov donskov deleted the mykhailoPV/disabled-dm-button-styles branch December 12, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donskov donskov donskov approved these changes

@MarikTar MarikTar Awaiting requested review from MarikTar

Assignees

@MykhailoPV MykhailoPV

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MykhailoPV @donskov @MarikTar