Add Chip #11
Merged
Add Chip #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MarikTar
commented
Apr 7, 2021
•
MarikTar
commented
- Make point 1 in New components added (Inputs with labels, Chips) #9
donskov
requested changes
Apr 8, 2021
| /** | ||
| * Used to render icon elements inside the Chip | ||
| */ | ||
| icon?: React.ReactNode; |
There was a problem hiding this comment.
For now, use the icon from mockups and don't allow to change the icon using props.
donskov
requested changes
Apr 9, 2021
| /** | ||
| * Used to render icon elements inside the Chip | ||
| */ | ||
| icon?: React.ReactNode; |
| dataTestId?: string; | ||
| }; | ||
|
|
||
| type ChipProps = BaseProps & React.ButtonHTMLAttributes<HTMLButtonElement>; |
There was a problem hiding this comment.
Now Chip component can use props from HTMLButtonElement, but you forgot to add ...other props to your root element.
| [stylesEffects()]: !selected || !isChoice, | ||
| [className]: !!className, | ||
| })} | ||
| tabIndex={selected && isChoice ? -1 : 1} |
There was a problem hiding this comment.
Need to use tabIndex from props for default state.
|
|
||
| type ChipProps = BaseProps & React.ButtonHTMLAttributes<HTMLButtonElement>; | ||
|
|
||
| const stylesBase = () => css({ |
There was a problem hiding this comment.
Chip it's an inline component (from mockup):
Current solution broken with multiple elements:
donskov
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.