Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New components added (Inputs with labels, Chips) #9

Open
alexgbv opened this issue Apr 1, 2021 · 2 comments
Open

New components added (Inputs with labels, Chips) #9

alexgbv opened this issue Apr 1, 2021 · 2 comments
Assignees
@donskov
Labels
enhancement New feature or request question Further information is requested

Comments

@alexgbv
Copy link

alexgbv commented Apr 1, 2021

1. Chips

Chips are used for filtrating content or for single selection:
image

https://www.figma.com/file/MJze0qkQ2bw0D1oelqqOUK/pv-design-system?node-id=5185%3A3446

2. Labels added to inputs and selects.

Labels added to input/selects/counters components as switchable option.
image
@alexgbv alexgbv added the enhancement New feature or request label Apr 1, 2021
@MarikTar MarikTar added the question Further information is requested label Apr 2, 2021
@MarikTar
Copy link
Contributor

MarikTar commented Apr 2, 2021

@alexgbv, I have some question:

  1. What state is this?
    image
  2. The icon will change?
  3. Where are these changes in the mockup?
    image

@alexgbv
Copy link
Author

alexgbv commented Apr 2, 2021

  1. "Selected" state.
  2. Icon will be optional, disabled by default. (Except of filtration chips with checkmarks)
  3. It is disabled by default. You can switch on it here.
    image

This was referenced Apr 2, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donskov donskov

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@donskov @alexgbv @MarikTar