Pre-Built SIPNET Binary for GitHub Actions #3435
Conversation
There was a problem hiding this comment.
Thanks for working on this! To meet the requirements of #3427 you'll need to make some changes:
- Building the binary should be done in the sipnet repo. Determining how to get the built binary from there to here is the crux of the task.
- In all repositories Github Actions workflows have to be in
.github/workflows, not in the project root. - The changes to PEcAn's CI should modify existing workflows rather than add new ones.
Sure I will look into this changes. |
|
i have made the required changes.can you please look into those. |
|
@AritraDey-Dev Looks good to me! I am not sure if Lines 61-73 of ci.yml need to be there, now that the binary building will be done elsewhere. I put a note in PecanProject/sipnet#27 and will update the curl statements once we have a release with binaries. |
|
@infotroph i have Updated upload-artifact to v3. SIPNET installation remains encapsulated in sipnet.yml, so no further modifications were needed. Let me know if anything else is required! |
| @@ -61,4 +61,4 @@ jobs: | |||
| uses: ./.github/workflows/sipnet.yml | |||
| with: | |||
| R-version: ${{ matrix.R }} | |||
| secrets: inherit | |||
| secrets: inherit | |||
There was a problem hiding this comment.
I don't understand this code diff, what has changed here? did you add a extra space or something ? if so why?
There was a problem hiding this comment.
i am also not sure,may be while coding there is some unnecessary spaces that came.I will revert it.
.github/workflows/sipnet.yml
Outdated
| run: | | ||
| cd ${GITHUB_WORKSPACE}/sipnet | ||
| make sipnet | ||
| curl -L -o sipnet-linux "https://drive.google.com/uc?export=download&id=1sRTFfs9Z9osmMrtLlwVTqxeUDxgVlrEv" |
There was a problem hiding this comment.
@dlebauer @infotroph are we sure that this drive link will always be live for our project ? joining mid way so do not have the best context
| cd ${GITHUB_WORKSPACE}/sipnet | ||
| make sipnet | ||
| curl -L -o sipnet-linux "https://drive.google.com/uc?export=download&id=1sRTFfs9Z9osmMrtLlwVTqxeUDxgVlrEv" | ||
| chmod +x sipnet-linux |
There was a problem hiding this comment.
Do we make use of sipnet-linux while building ?
There was a problem hiding this comment.
#3427 here the binary shared for linux i have updated that.
AritraDey-Dev
force-pushed
the
fix_pre-built-sipnet
branch
from
606f9fa to
17a0d0b
Compare
Fixes PecanProject#3427 Add CI workflow to build and upload SIPNET binary as an artifact and update PEcAn workflow to use pre-built SIPNET binary. * **ci.yml** - Add steps to build SIPNET binary. - Add steps to upload SIPNET binary as an artifact. * **sipnet.yml** - Remove steps to check out and build SIPNET from source. - Add steps to download pre-built SIPNET binary. - Add steps to use pre-built SIPNET binary. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/PecanProject/pecan/issues/3427?shareId=XXXX-XXXX-XXXX-XXXX).
- Added steps to download SIPNET binaries directly from Google Drive. - Removed the compilation step to streamline the workflow.
AritraDey-Dev
force-pushed
the
fix_pre-built-sipnet
branch
from
de53a10 to
6fd5195
Compare
Fixes #3427
Add CI workflow to build and upload SIPNET binary as an artifact and update PEcAn workflow to use pre-built SIPNET binary.
ci.yml
sipnet.yml
For more details, open the Copilot Workspace session.