Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support-symfony-6, except for symfony/http-foundation #934

Merged
merged 1 commit into from
May 5, 2022

Conversation

Chris53897
Copy link
Contributor

getMasterRequest() is removed in Symfony 6.
https://github.com/symfony/http-foundation/blob/6.0/CHANGELOG.md#60

This PR builds a small BC layer to support symfony 4-6.

PhpUnit needs to be allow 9.5 otherwise tests will fail. This is because of the mocking of Symfony/Form and more.
Error : Call to undefined method ReflectionUnionType::getName() /Payum/src/Payum/Core/Tests/Bridge/Symfony/Action/ObtainCreditCardActionTest.php:383 /Payum/src/Payum/Core/Tests/Bridge/Symfony/Action/ObtainCreditCardActionTest.php:83

The symfony/http-foundation in version 6 is excluded because of #933

@Chris53897
Copy link
Contributor Author

Test fail again because of PhpUnit 9 deprecation at()

@pierredup
Copy link
Member

@Chris53897 I have switched the branch to 1.x, since this is a new feature that should go into the next minor 1 release (The branch 1.7.x is for bug-fixes against the 1.7 version only).

Test fail again because of PhpUnit 9 deprecation at()

Is phpunit 9 necessary for this change? Otherwise it can be removed, I'll work on a separate PR to support PhpUnit 9 then

@pierredup pierredup changed the base branch from 1.7.x to 1.x May 5, 2022 09:27
@Chris53897
Copy link
Contributor Author

ok, thanks.

Yes PhpUnit 9 is necessary, otherwise tests will fail for symfony 6. See ErrorMessage above.
For 2.x the work is already done.
An improvment could be to rewrite the tests for the ->at() Deprecations.
But this has no priority in my eyes for the moment.

@pierredup
Copy link
Member

pierredup commented May 5, 2022

For 2.x the work is already done.
An improvment could be to rewrite the tests for the ->at() Deprecations.
But this has no priority in my eyes for the moment.

I'll work on removing the at calls, and will merge the changes into your PR at #932. That way, we can get the build green for that PR. I'll also change the target to 1.x, since it's something that can be merged into the next minor release for version 1, and will help with other changes going forward (E.G this PR)

@Chris53897
Copy link
Contributor Author

Sounds good. Thanks

I target the wrong branch again. Shame on me. Sorry

@pierredup pierredup added this to the 1.8.0 milestone May 5, 2022
@pierredup
Copy link
Member

Thank you @Chris53897

@pierredup pierredup merged commit 579b3a2 into Payum:1.x May 5, 2022
@Chris53897 Chris53897 deleted the feature/support-symfony-6 branch May 6, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants