Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PP_CONFIG_PATH as default config_path and make config_path optional #815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexander-schranz
Copy link

@alexander-schranz alexander-schranz commented Sep 2, 2019

To make integration easier the default should be read from the PP_CONFIG_PATH so e.g. in a symfony/sylius application you could define this in your over env or a config/bootstrap.php file and get the client_id and client_secret over the DynamicRegistry from a database.

Also I don't think that the config_path is really a requirement for Paypal Api when looking at there wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant