Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support symfony/http-foundation in version 6 (no objects as request query-paramters) #933

Open
Chris53897 opened this issue May 5, 2022 · 2 comments

Comments

@Chris53897
Copy link
Contributor

The symfony/http-foundation does not allow to set objects as query Parameters to requests in version 6.
This looks reasonable for me.

The test fails here https://github.com/Payum/Payum/blob/master/src/Payum/Core/Tests/Bridge/Symfony/Security/HttpRequestVerifierTest.php#L169

It is in the group legacy so it may be will a solution to make the test skippable for symfony 6?

@vasilvestre
Copy link

May be closed now with the PR accepted

@Chris53897
Copy link
Contributor Author

The PR exclude symfony/http-foundation in version 6. I hope @pierredup knows if we can just delete this tests in the next major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants