Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SlimeLoader#renameWorld #83

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

dementisimus
Copy link

@dementisimus dementisimus commented Oct 31, 2021

This PR allows to rename worlds by SlimeLoader#renameWorld

Redis support will be postponed.

to-do:

  • add mongo support
  • add mysql support
    (- [ ] add redis support)
  • add file support

@dementisimus
Copy link
Author

  • add redis support

due to some unexpected issues with redis

  • java.lang.NoClassDefFoundError: io/netty/resolver/dns/DnsCnameCache
  • java.lang.NoSuchMethodError: io.netty.resolver.dns.DnsNameResolverBuilder.socketChannelType(java.lang.Class) (even with 4.1.63.Final)

I won't be adding redis support now. I will be working on fixing this issue with redis. If this issue has been fixed, I will open an additional PR for adding redis support to SlimeLoader#renameWorld.

@dementisimus dementisimus marked this pull request as ready for review November 1, 2021 12:33
Copy link
Owner

@Paul19988 Paul19988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do not intend to add Redis support for now, please ensure that it informs the user when attempting to do it whilst using redis (implement an UnsupportedOperationException)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants