Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core pattern to exchange form data via JavaScript events #892

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions src/core/form-data-event.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
import Base from "./base";
import Parser from "./parser";
import logging from "./logging";

const log = logging.getLogger("form-data-event");

export const parser = new Parser("form-data-event");
parser.attribute = "data-form-data-event"; // do not require ``data-pat-``
parser.addArgument("event-name-submit");
parser.addArgument("event-name-init");
parser.addArgument("prevent-submit", true);

export default Base.extend({
name: "form-data-event",
trigger: ".form-data-event", // note: no .pat- trigger!

init() {
this.options = parser.parse(this.el, this.options);
if (this.el.tagName !== "FORM") {
log.warn("pattern must be initialized on a form element.");
return;
}
if (this.options.event["name-submit"]) {
this.el.addEventListener("submit", this.handle_submit.bind(this));
}
if (this.options.event["name-init"]) {
document.addEventListener(
this.options.event["name-init"],
this.handle_init.bind(this),
{ once: true }
);
}
},

handle_submit(e) {
if (this.options.preventSubmit) {
e.preventDefault();
}
// Note: line breaks might change from /n to /r
const form_data = new FormData(this.el);
if (e.submitter?.name) {
form_data.append("action", e.submitter.name);
}
const ev = new CustomEvent(this.options.event["name-submit"], {
detail: { form_data: form_data },
});
document.dispatchEvent(ev);
if (this.options.event["name-init"]) {
document.removeEventListener(
this.options.event["name-init"],
this.handle_init
);
}
},

handle_init(e) {
const form_data = e?.detail?.form_data;
for (const [key, value] of form_data.entries()) {
const _el = this.el.querySelector(`[name=${key}]`);
if (_el) {
if (_el.type === "checkbox") {
// TODO:
// should set checked=true if value exists and set the checkbox value to the form_data value?
// then we need some logic to unset the checkbox if value is omitted.
_el.checked = value === "true" || value === "on"; // default value for checked checkboxes is "on"
} else {
_el.value = value;
}
}
}
},
});
113 changes: 113 additions & 0 deletions src/core/form-data-event.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
import "./form-data-event";
import registry from "./registry";
import utils from "./utils";

describe("form-data-event: Pass form data via events.", () => {
afterEach(() => {
document.body.innerHTML = "";
});

it("Initializes a form with data when receiving an initialization event, but only once", async () => {
document.body.innerHTML = `
<form
class="form-data-event"
data-form-data-event="
event-name-init: init-event
">
<input type="text" name="inp1" />
<input type="text" name="inp2" />
<input type="checkbox" name="inp3" />
<textarea name="inp4"></textarea>
</form>
`;

registry.scan(document.body);

const longer_text = `HalloGallo
Sonderangebot
Weissensee
Jahresüberblick
Im Glück
Negativland
Lieber Honig`;

const form_data = new FormData();
form_data.append("inp1", "Neu!");
form_data.append("inp2", "1972");
form_data.append("inp3", true);
form_data.append("inp4", longer_text);

const init_event = new CustomEvent("init-event", {
detail: { form_data: form_data },
});
document.dispatchEvent(init_event);

await utils.timeout(1);

const form = document.querySelector("form");
expect(form.querySelector("[name=inp1]").value).toBe("Neu!");
expect(form.querySelector("[name=inp2]").value).toBe("1972");
expect(form.querySelector("[name=inp3]").checked).toBe(true);
expect(form.querySelector("[name=inp4]").value).toBe(longer_text);

// Another initialization Event won't change the form again
// The reason for the once-registration of the event is to prevent
// unused event handlers to be hanging around.

const form_data_2 = new FormData();
form_data_2.append("inp1", "Kraftwerk");
form_data_2.append("inp2", "Autobahn");
form_data_2.append("inp3", false);
form_data_2.append("inp4", "");

const init_event_2 = new CustomEvent("init-event", {
detail: { form_data: form_data_2 },
});
document.dispatchEvent(init_event_2);

await utils.timeout(1);

expect(form.querySelector("[name=inp1]").value).toBe("Neu!");
expect(form.querySelector("[name=inp2]").value).toBe("1972");
expect(form.querySelector("[name=inp3]").checked).toBe(true);
expect(form.querySelector("[name=inp4]").value).toBe(longer_text);
});

it("Passes form data via an submit event", async () => {
// Note: line breaks might change from /n to /r
// Testing without line breaks for now.
const longer_text = `Autobahn, Kometenmelodie 1, Kometenmelodie 2, Mitternacht, Morgenspaziergang`;

document.body.innerHTML = `
<form
class="form-data-event"
data-form-data-event="
event-name-submit: submit-event
">
<input type="text" name="inp1" value="Kraftwerk" />
<input type="text" name="inp2" value="Autobahn" />
<input type="checkbox" name="inp3" value="on" checked />
<textarea name="inp4">${longer_text}</textarea>
</form>
`;

registry.scan(document.body);

let form_data;
document.addEventListener("submit-event", (e) => {
form_data = e.detail.form_data;
});

const form = document.querySelector("form");

form.dispatchEvent(new Event("submit"));

await utils.timeout(1);

expect(form_data instanceof FormData).toBeTruthy();
expect(form_data.get("inp1")).toBe("Kraftwerk");
expect(form_data.get("inp2")).toBe("Autobahn");
expect(form_data.get("inp3")).toBe("on");
expect(form_data.get("inp4")).toBe(longer_text);
});
});