Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully Updated Landing Box and Interaction Viewer #644

Merged
merged 38 commits into from
Apr 9, 2018

Conversation

logmosier
Copy link
Collaborator

I made a branch and merged all the changes I had that where waiting for PRs into 1 branch. There is no need to merge PR #608 if we merge this.
Changes in this PR as a full are:

Changes to interactions/index.js:

  • All networkMetadata now fetched by ServerAPI. getGeneInformation
  • Only trim the network if the number of found ids = to the number of quired genes (this stops the case where the quried gene may be removed by trimming)
  • findId() removed and changes to parse are because ids are now found in ServerAPI. getGeneInformation
  • Add message when no network is found (sometimes PathsBetween does not return a network)

Changes to search/index.js:

  • Removed code dealing with the landing box

Changes to search/landing.js (apart from creating it):

  • logic of getLandingResult() changed to handle NCBI database
    • get database ids of genes searched ( all but ENTREZGENE_ACC are just used for links)->merge all the ids in to a easy to use object-> if there are ids get gene information from NCBI with ENTREZGENE_ACC-> format the returned content into a easy to use object
  • handelShowMoreClick and expandableText added to cut down on repeated code
  • landing box no longer handles extraction of useful bits from fetched data (handled by getLandingResults)

@d2fong d2fong merged commit b562f16 into PathwayCommons:development Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants