Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-gene searches #520

Closed
logmosier opened this issue Mar 15, 2018 · 7 comments
Closed

Multi-gene searches #520

logmosier opened this issue Mar 15, 2018 · 7 comments

Comments

@logmosier
Copy link
Collaborator

Right now if the user enters multiple genes in the search the landing box does not appear and the user does not have the ability to access the interactions app. A better solution to this situation should be implemented.
I think the landing box could look something like this
screen shot 2018-03-15 at 12 55 45 pm
When the user clicks on more they will be shown the content that would come up from a search of only that gene.

The interactions app could either show the paths between the genes searched or could show the nodes from both of the neighbourhoods interweaved.

Paths between:
pros- would likely be a smaller network,
cons- differs from the behaviour of single gene searches which could be confusing

Multiple neighbourhoods:
pros-in line with current behaviour, not likely to have any unexpected/confusing behaviour for the user
cons-the network could be extremely large

Also with in the Interactions app I think there should be a way for the user to add new queried genes to the view. This could be added to the filter menu or could be included in its own menu accesed through the toolbar.

@jvwong
Copy link
Member

jvwong commented Mar 15, 2018

Nice! I can see this working.
One reservation with multiple neighbourhoods is the 'interweave' part - that sounds like 'merging' and could get ugly. I think for pathsbetween you can set a limit:

limit= [Optional] graph query search distance limit (default = 1).

Your add gene idea is interesting, and starts to sound a lot like GeneMania was intended to do.

Also I'm gonna leave this 'big picture' idea, that kinda looks at all of this, including @wxli0 's enrichment services as all different aspects of search...
unified_search

@logmosier
Copy link
Collaborator Author

Waiting on PR #535

@logmosier
Copy link
Collaborator Author

The one problem I can think of is the pathsbetween gives some results that may confuse the user. For instance if you search for ATM and MDM2 which have networks like
screen shot 2018-03-21 at 12 58 15 pm
screen shot 2018-03-21 at 12 58 09 pm
you get a network like
screen shot 2018-03-21 at 12 57 54 pm
from pathsBetween. This is without setting limit so it may be better by adjusting limit but as a user I think this would be confusing why the view with both of them is much smaller.

@jvwong
Copy link
Member

jvwong commented Mar 21, 2018

Let's assume that the user types in two genes in hopes of answering the question: "Are there known instances where these genes (directly) interact?". In that case, I believe the pathsbetween result is spot on, with one small exception...

I looked at the SIF responses in Cytoscape for either ATM or MDM2 (neighborhood) and both (pathsbetween). I stripped out everything but the two proteins.

A) ATM
image

B) MDM2
image

C) ATM and MDM2
image

So the dual gene search drops the interacts-with (for some reason? @IgorRodchenkov) but, looks great to me. In fact, you could probably skip the trimming step here if you want.

@IgorRodchenkov
Copy link
Member

IgorRodchenkov commented Mar 21, 2018 via email

@IgorRodchenkov
Copy link
Member

Off-topic:
also mind issue #438 that depends on PathwayCommons/cpath2#284 and BioPAX/Paxtools#34 - both are fixed but won't have effect until the next PC release (PC10).
Hopefully, neighborhood query results won't be so large.

@ozgunbabur
Copy link

ozgunbabur commented Mar 21, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants