Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate Gallic culture when converting to TFE #1513

Merged
merged 19 commits into from
Sep 2, 2023

Conversation

IhateTrains
Copy link
Member

@IhateTrains IhateTrains added the enhancement New feature or request label Sep 2, 2023
language = language_babylonian
martial_custom = martial_custom_male_only
traditions = {
# Babylonian culture should have City Keepers tradition as Babylonians built cities as beautiful works of art. (The use of brick led to the early development of the pilaster and column, and of frescoes and enameled tiles. The walls were brilliantly coloured, and sometimes plated with zinc or gold, as well as with tiles. Painted terracotta cones for torches were also embedded in the plaster. (from the Babylonia Wikipedia page))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"coloured" is a misspelling of "colored"

# Babylonian culture should have City Keepers tradition as Babylonians built cities as beautiful works of art. (The use of brick led to the early development of the pilaster and column, and of frescoes and enameled tiles. The walls were brilliantly coloured, and sometimes plated with zinc or gold, as well as with tiles. Painted terracotta cones for torches were also embedded in the plaster. (from the Babylonia Wikipedia page))
tradition_city_keepers

# Babylonian culture should have Medicinal Herbalists tradition because Babylonians introduced one of the earliest medical activities. (… the Babylonians introduced the concepts of diagnosis, prognosis, physical examination, and prescriptions. In addition, the Diagnostic Handbook introduced the methods of therapy and aetiology and the use of empiricism, logic and rationality in diagnosis, prognosis and therapy. (from the Babylonia Wikipedia page))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"aetiology" is a misspelling of "etiology"

# Babylonian culture should also have Storytellers tradition since Babylonians (and Sumerians) emphasized the role of literature, such as the epic of Gilgamesh. (There were libraries in most towns and temples; an old Sumerian proverb averred that "he who would excel in the school of the scribes must rise with the dawn". Women as well as men learned to read and write. (from the Babylonia Wikipedia page))
tradition_storytellers

# Babylonian culture should have Philosopher Culture tradition as Babylonian philosophy had an influence on Greek philosophy, particularly Hellenistic philosophy. The Babylonian text Dialogue of Pessimism contains similarities to the agonistic thought of the sophists, the Heraclitean doctrine of contrasts, and the dialogs of Plato, as well as a precursor to the maieutic Socratic method of Socrates. (from the Babylonia Wikipedia page)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"Dialogue" is a misspelling of "Dialog"

traditions = {
tradition_horse_breeder
tradition_pastoralists
tradition_martial_admiration # "… He also states that "Ares," the god of war, was the only god to whom the Scythians dedicated statues, altars or temples. Tumuli were erected to him in every Scythian district, and both animal sacrifices and human sacrifices were performed in honor of him. At least one shrine to "Ares" has been discovered by archaeologists." (from the Scythians Wikipedia page)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"archaeologists" is a misspelling of "archeologists"

@IhateTrains IhateTrains merged commit 48377fc into master Sep 2, 2023
10 checks passed
@IhateTrains IhateTrains deleted the tweaks-for-tfe branch September 2, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant