Skip to content

Commit

Permalink
Make mapping classes internal
Browse files Browse the repository at this point in the history
  • Loading branch information
IhateTrains committed Aug 12, 2024
1 parent 67cb67f commit 7395aee
Show file tree
Hide file tree
Showing 12 changed files with 15 additions and 11 deletions.
4 changes: 4 additions & 0 deletions ImperatorToCK3/ImperatorToCK3.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,10 @@
</ItemGroup>
</Target>

<ItemGroup>
<InternalsVisibleTo Include="ImperatorToCK3.UnitTests" />
</ItemGroup>

<ItemGroup>
<!-- root descriptors for trimming -->
<TrimmerRootAssembly Include="log4net" />
Expand Down
2 changes: 1 addition & 1 deletion ImperatorToCK3/Mappers/DeathReason/DeathReasonMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace ImperatorToCK3.Mappers.DeathReason;

public sealed class DeathReasonMapping {
internal sealed class DeathReasonMapping {
public SortedSet<string> ImperatorReasons { get; } = new();
public string? Ck3Reason { get; private set; }

Expand Down
2 changes: 1 addition & 1 deletion ImperatorToCK3/Mappers/Government/GovernmentMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace ImperatorToCK3.Mappers.Government;

public sealed class GovernmentMapping {
internal sealed class GovernmentMapping {
public string CK3GovernmentId { get; private set; } = "";
public SortedSet<string> ImperatorGovernmentIds { get; } = [];
public SortedSet<string> ImperatorCultureIds { get; } = [];
Expand Down
2 changes: 1 addition & 1 deletion ImperatorToCK3/Mappers/Nickname/NicknameMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace ImperatorToCK3.Mappers.Nickname;

public sealed class NicknameMapping {
internal sealed class NicknameMapping {
public SortedSet<string> ImperatorNicknames { get; } = new();
public string? CK3Nickname { get; private set; }

Expand Down
2 changes: 1 addition & 1 deletion ImperatorToCK3/Mappers/Province/ProvinceMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace ImperatorToCK3.Mappers.Province;

public sealed class ProvinceMapping {
internal sealed class ProvinceMapping {
public IList<ulong> CK3Provinces { get; } = new List<ulong>();
public IList<ulong> ImperatorProvinces { get; } = new List<ulong>();

Expand Down
2 changes: 1 addition & 1 deletion ImperatorToCK3/Mappers/Province/ProvinceMappingsVersion.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace ImperatorToCK3.Mappers.Province;

public sealed class ProvinceMappingsVersion {
internal sealed class ProvinceMappingsVersion {
public IList<ProvinceMapping> Mappings { get; } = [];
public ProvinceMappingsVersion() { }
public ProvinceMappingsVersion(BufferedReader reader) {
Expand Down
2 changes: 1 addition & 1 deletion ImperatorToCK3/Mappers/Religion/ReligionMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace ImperatorToCK3.Mappers.Religion;

public sealed class ReligionMapping {
internal sealed class ReligionMapping {
private readonly SortedSet<string> irReligionIds = [];
public string? CK3FaithId { get; private set; }
private readonly SortedSet<string> ck3CultureIds = [];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace ImperatorToCK3.Mappers.SuccessionLaw;

public sealed class SuccessionLawMapping {
internal sealed class SuccessionLawMapping {
public string ImperatorLaw { get; set; } = "";
public SortedSet<string> CK3SuccessionLaws { get; } = new();
public SuccessionLawMapping(BufferedReader mappingReader) {
Expand Down
2 changes: 1 addition & 1 deletion ImperatorToCK3/Mappers/TagTitle/RankMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace ImperatorToCK3.Mappers.TagTitle;

public sealed class RankMapping {
internal sealed class RankMapping {
public RankMapping(BufferedReader mappingReader) {
var parser = new Parser();
parser.RegisterKeyword("ir", reader => irRank = reader.GetString());
Expand Down
2 changes: 1 addition & 1 deletion ImperatorToCK3/Mappers/TagTitle/TitleMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

namespace ImperatorToCK3.Mappers.TagTitle;

public sealed class TitleMapping {
internal sealed class TitleMapping {
public string? RankMatch(string irTagOrRegion, TitleRank rank, TitleRank maxTitleRank) {
if (imperatorTagOrRegion != irTagOrRegion) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion ImperatorToCK3/Mappers/Trait/TraitMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace ImperatorToCK3.Mappers.Trait;

public sealed class TraitMapping {
internal sealed class TraitMapping {
public SortedSet<string> ImperatorTraits { get; } = new();
public string? CK3Trait { get; set; }

Expand Down
2 changes: 1 addition & 1 deletion ImperatorToCK3/Mappers/War/WarMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace ImperatorToCK3.Mappers.War;

public sealed class WarMapping {
internal sealed class WarMapping {
public SortedSet<string> ImperatorWarGoals { get; set; } = new();
public string? CK3CasusBelli { get; set; }

Expand Down

0 comments on commit 7395aee

Please sign in to comment.