Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ability for org billing leader and org admin to delete meeting templates #10902

Merged
merged 1 commit into from
Feb 20, 2025
Merged

feat: add ability for org billing leader and org admin to delete meeting templates #10902

merged 1 commit into from
Feb 20, 2025

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Feb 20, 2025 •
edited
Loading

Description

Fixes #10722

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe linked an issue Feb 20, 2025 that may be closed by this pull request
Org admin can delete templates #10722
Closed
@tianrunhe tianrunhe force-pushed the 10722/orgAdminCanDeleteTemplates branch from 2d64bb6 to 189beaa Compare February 20, 2025 00:50
@tianrunhe tianrunhe added the Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved label Feb 20, 2025
@tianrunhe tianrunhe merged commit f32c0aa into master Feb 20, 2025
7 checks passed
@tianrunhe tianrunhe deleted the 10722/orgAdminCanDeleteTemplates branch February 20, 2025 17:21
@parabol-release-bot parabol-release-bot bot mentioned this pull request Feb 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickoferrall nickoferrall nickoferrall approved these changes

Assignees
No one assigned
Labels
size/s Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Org admin can delete templates
2 participants
@tianrunhe @nickoferrall