fix: Indentation in Comment Replies

[iamsmruti]

Description

Fixes/Partially Fixes #10776
I had to change some styling in a few components

Demo

Final checklist

• I checked the code review guidelines
• I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
• I have performed a self-review of my code, the same way I'd do it for any other team member
• I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
• Whenever I took a non-obvious choice I added a comment explaining why I did it this way
• I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
• PR title is human readable and could be used in changelog

[mattkrick]

Thanks for the PR! @ackernaut is this looking right? IMO maybe we can move the reply-line avatars to the left about 28px to get another word in? I couldn't find the original spec in figma, so i'll let you make the call

[ackernaut]

Hello! Thanks for looking at this. I don’t think the changes in the initial commit are the right idea, or what we need.

There is simply a parent div to the .ProseMirror div that has a tailwind class px-4. I think this was borrowed from the task cards, which do need inner padding. The comments do not.

I think the fix is to simply remove the .px-4 class, just 1 LOC. We’d need to check that it is not some global container shared with the task cards, because those do need the inner padding.

I’m also not sure we need the .min-h-10 but I’d have to check other places.

See screenshots for the markup.

[iamsmruti]

I see, I will revisit the changes I had proposed.

[iamsmruti]

Removing the px-4 impacts in a lot of places, such as

1. The Standup Spaces
2. Tasks

Same editor component is being used in around 10+ components. So, we need to do the impact analysis.

And min-h-10 adds some spacing in the tasks editing space and in the comments as well. If we remove it we might need to fix the padding.

[ackernaut]

Ah, good find @iamsmruti that it affects a lot of places. I wonder if there is a way to account for this in the thread* component using the editor. Or we should not add the padding to the global editor component, and apply the appropriate inner padding as needed at each specific component, that might have us touch half a dozen components or so. I’m happy to look more a little later.