-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove old upgrade payment logic #10860
base: master
Are you sure you want to change the base?
Conversation
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size. |
You are removing the conversion modal. I don't see that mentioned in the issue or the PR. Was this discussed with sales? |
Yep, that was discussed here: https://parabol.slack.com/archives/C029ZTH0EL9/p1739289011187399 I should have included it in the PR description. I'll add it there now. |
import type {Kysely} from 'kysely' | ||
|
||
export async function up(db: Kysely<any>): Promise<void> { | ||
await db.schema.alterTable('NewMeeting').dropColumn('showConversionModal').execute() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 let's remove the payLaterClickCount
fields from User
and Organization
as well, because it isn't updated anywhere anymore
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size. |
Fix #9887
This includes removing the conversion modal, discussed in Slack here 🔒 : https://parabol.slack.com/archives/C029ZTH0EL9/p1739289011187399
To test
stripe listen --forward-to localhost:3000/stripe
to a terminal to be able to upgrade.