Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed comment text removing indention #10776

Open
ackernaut opened this issue Jan 31, 2025 · 5 comments · May be fixed by #10869
Open

Fixed comment text removing indention #10776

ackernaut opened this issue Jan 31, 2025 · 5 comments · May be fixed by #10869
Assignees
Labels
bug p4 Should be addressed eventually

Comments

@ackernaut
Copy link
Member

Since updating to Tiptap comments have indention.

Filing it as a styling issue bug.

Image

AC

  • Removed the indention

EE

  • 2 hrs
@ackernaut ackernaut added the bug label Jan 31, 2025
@github-project-automation github-project-automation bot moved this to To triage in Product Jan 31, 2025
@iamsmruti
Copy link
Contributor

@ackernaut I would like to work on this issue. Please assign it to me.

@iamsmruti
Copy link
Contributor

@ackernaut Would you please provide more details on the Acceptance Criteria? I have figured out the issue, just need to verify if indentation has to be removed from both sides. or just from the left.

If we are removing it from both sides, we get something like this

Image

@ackernaut ackernaut moved this from To triage to Ready in Product Feb 13, 2025
@ackernaut
Copy link
Member Author

ackernaut commented Feb 13, 2025

Hello @iamsmruti sorry for the delay here. I want to say that there’s unnecessary padding on a container div using .px-4. But I’m not sure why it would’ve been added, maybe just inadvertently copied from a similar component elsewhere. There are replies, and tasks that can be added, so we would need to check that replies are indented properly.

Edit: when the replies are indented it is the whole comment block, including the avatar, meta info, etc. But the reply comment should still be aligned with the name.

@ackernaut
Copy link
Member Author

If you submit a PR I can review it. @iamsmruti

@iamsmruti iamsmruti linked a pull request Feb 13, 2025 that will close this issue
7 tasks
@iamsmruti
Copy link
Contributor

@ackernaut I have fixed the indentation, have a look at the changes #10869. Let me know what you think

@jordanh jordanh added the p4 Should be addressed eventually label Feb 17, 2025
@jordanh jordanh moved this from Ready to In progress in Product Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p4 Should be addressed eventually
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants