Skip to content

Adding more options for configuring ping passthrough. #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: dev/3.0.0
Choose a base branch
from

Conversation

TheMiningTeamYT
Copy link

When using Velocity, I have been frustrated by the lack of fine control over ping passthrough, specifically the lack of support for passing through favicons without passing through the whole ping request. I've also seen people on line asking how to pass through favicons, so I decided to add the ability to control which aspects of server list ping requests are passed through from the back end server, and which aspects aren't, through 5 new boolean configuration options in the config file.
Please don't judge my code too harshly, this is my first time writing Java, but it does compile and Checkstyle is okay with it.
(If you're wondering, yes this is a duplicate pull request -- sorry about that, I was told to make a new pull request from a different branch. However, the code has been updated since I originally opened the old pull request. Not since I closed the previous pull request though.)

@TheMiningTeamYT
Copy link
Author

I cleaned up my commits (specifically I removed the times I merged from upstream from the ping-passthrough-dev branch), so there is actually a reason for this new pull request now. I hope you will reevaluate my pull request in light of this.

@TheMiningTeamYT
Copy link
Author

I've now gone through the trouble of resolving the merge conflict (so I can have an up-to-date version of Velocity build from my fork), merged ping-passthrough-dev, and tested the result. It builds, and, although I haven't thoroughly tested it, it does work.
I believe this is now in a merge-able state. It functions, maintains compatibility with existing configurations, and brings a useful new feature to Velocity: more granular control of ping passthrough. (I made this fork out of necessity in the first place, and I'm sure others will find this feature useful too). Plus, I've already gone through the trouble of resolving the merge conflicts, and running the build tests (when I merged the branch on my fork). All you have to do is click the button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant