Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support deleting multiple custom registries #219

Merged
merged 4 commits into from
Dec 15, 2024

Conversation

chouchouji
Copy link
Contributor

@chouchouji chouchouji commented Dec 8, 2024

Issue

close #215

Result

20241210-161621.mp4

Copy link

changeset-bot bot commented Dec 8, 2024

🦋 Changeset detected

Latest commit: b224d76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nrm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chouchouji chouchouji force-pushed the feat-delete-multiple-registry branch from 99b7bc3 to df2c456 Compare December 10, 2024 08:11
@chouchouji
Copy link
Contributor Author

@iosh I have implemented the need, Please add test cases in this pr. Thanks.

@iosh
Copy link
Collaborator

iosh commented Dec 10, 2024

Sorry, I will review it as soon as possible (been a bit busy lately).

@iosh
Copy link
Collaborator

iosh commented Dec 10, 2024

@iosh I have implemented the need, Please add test cases in this pr. Thanks.

OK, but not sure if it can be completed this week.

@chouchouji
Copy link
Contributor Author

Sorry, I will review it as soon as possible (been a bit busy lately).

Thanks.

@chouchouji
Copy link
Contributor Author

@iosh I have implemented the need, Please add test cases in this pr. Thanks.

OK, but not sure if it can be completed this week.

I think this task is not urgent. We can complete it when you are free.

@iosh
Copy link
Collaborator

iosh commented Dec 14, 2024

@chouchouji Please review this when you have time . Thanks.

@chouchouji
Copy link
Contributor Author

@chouchouji Please review this when you have time . Thanks.

LGTM.

@chouchouji chouchouji force-pushed the feat-delete-multiple-registry branch 2 times, most recently from 4fe5b2c to b224d76 Compare December 14, 2024 15:36
@iosh iosh merged commit b449962 into Pana:master Dec 15, 2024
9 checks passed
@chouchouji chouchouji deleted the feat-delete-multiple-registry branch December 17, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support deleting multiple custom registries
2 participants