-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Support for User Family Members #1768
Added Support for User Family Members #1768
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1768 +/- ##
===========================================
- Coverage 98.17% 97.67% -0.51%
===========================================
Files 184 234 +50
Lines 10767 14185 +3418
Branches 835 1173 +338
===========================================
+ Hits 10571 13855 +3284
- Misses 186 298 +112
- Partials 10 32 +22 ☔ View full report in Codecov by Sentry. |
@palisadoes All the work is completed from my side. |
We have a policy of unassigning contributors who close PRs without getting validation from our reviewer team. This is because:
Please be considerate of our volunteers' limited time and our desire to improve our code base. This policy is stated as a pinned post in all our Talawa repositories. Our YouTube videos explain why this practice is not acceptable to our Community. I asked three reviewers to look at your PR only for it to be closed. There was no good reason for this. I have closed this one and reopened the previous one so that the reference stands. |
Please do not do this again. |
What kind of change does this PR introduce?
Add Support for User Family Members
Issue Number:
Fixes #1584
Did you add tests for your changes?
Yes
Snapshots/Videos:
If relevant, did you update the documentation?
Not relevant
Summary
Does this PR introduce a breaking change?
No
Other information
All the tests related to my part has been passed and verified.
Have you read the contributing guide?
Yes