Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for User Family Members #1768

Conversation

AdityaRaimec22
Copy link
Contributor

What kind of change does this PR introduce?
Add Support for User Family Members

Issue Number:

Fixes #1584

Did you add tests for your changes?
Yes

Snapshots/Videos:

If relevant, did you update the documentation?
Not relevant

Summary

Does this PR introduce a breaking change?
No

Other information
All the tests related to my part has been passed and verified.

Have you read the contributing guide?
Yes

@AdityaRaimec22 AdityaRaimec22 changed the title New family branch Added Support for User Family Members Jan 31, 2024
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 158 lines in your changes are missing coverage. Please review.

Comparison is base (c0468a4) 98.17% compared to head (dd89d6f) 97.67%.
Report is 209 commits behind head on develop.

Files Patch % Lines
...olvers/Mutation/adminRemoveMemberFromUserFamily.ts 54.54% 65 Missing ⚠️
...c/resolvers/Mutation/adminAddMemberToUserFamily.ts 81.72% 17 Missing ⚠️
src/libraries/errors/ImageSizeLimitExceeded.ts 27.27% 16 Missing ⚠️
src/resolvers/Mutation/updateUserProfile.ts 70.90% 1 Missing and 15 partials ⚠️
src/resolvers/Mutation/createEvent.ts 83.51% 13 Missing and 2 partials ⚠️
src/resolvers/middleware/currentUserExists.ts 45.83% 13 Missing ⚠️
src/resolvers/Mutation/createPost.ts 90.32% 6 Missing ⚠️
src/resolvers/Mutation/createOrganization.ts 95.78% 4 Missing ⚠️
src/resolvers/Mutation/removeAdvertisement.ts 92.85% 2 Missing ⚠️
...c/resolvers/Query/postsByOrganizationConnection.ts 33.33% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1768      +/-   ##
===========================================
- Coverage    98.17%   97.67%   -0.51%     
===========================================
  Files          184      234      +50     
  Lines        10767    14185    +3418     
  Branches       835     1173     +338     
===========================================
+ Hits         10571    13855    +3284     
- Misses         186      298     +112     
- Partials        10       32      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdityaRaimec22
Copy link
Contributor Author

@palisadoes All the work is completed from my side.

@palisadoes palisadoes closed this Jan 31, 2024
@palisadoes
Copy link
Contributor

We have a policy of unassigning contributors who close PRs without getting validation from our reviewer team. This is because:

  1. We start looking for people to review PRs when you submit them.
  2. We often contact them and link to the PR. If the PR is closed the whole effort is wasted.
  3. The historical thread of reviewer comments is broken when the work is spread across multiple PRs. The quality of our code is affected negatively.

Please be considerate of our volunteers' limited time and our desire to improve our code base.

This policy is stated as a pinned post in all our Talawa repositories. Our YouTube videos explain why this practice is not acceptable to our Community.


I asked three reviewers to look at your PR only for it to be closed. There was no good reason for this. I have closed this one and reopened the previous one so that the reference stands.

@palisadoes
Copy link
Contributor

Please do not do this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants