Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for User Family Members #1584

Closed
palisadoes opened this issue Dec 27, 2023 · 19 comments
Closed

Add Support for User Family Members #1584

palisadoes opened this issue Dec 27, 2023 · 19 comments
Assignees

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Dec 27, 2023

Is your feature request related to a problem? Please describe.

  1. To be even more useful to Administrators, there needs to be the ability to group Users as members of the same family.
  2. When implemented in the API, the Admin Portal will be able to visualize and edit the family group members of each user in the user profile page.

Describe the solution you'd like

  1. We should have the ability to add, and remove people from families.
  2. Families can only be valid if there are more than one member. Therefore when:
    1. there is only one member in a group, the family group entry should be empty
    2. a new family is created, the family group instantaneously has two family members
  3. Other functionality must not be affected
  4. You must write tests to validate your work

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • N/A

Additional context

  • Work with @xoldyckk on evaluating your solution here and in the subsequent PR
  • This may be a prerequisite for our menu of project ideas for GSoC 2024

Potential internship candidates

@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Dec 27, 2023
@monkCommits
Copy link

Please assign me this issue.

@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label Dec 27, 2023
@monkCommits
Copy link

Hey, do you want me to write the api in one of the existing files or should I create a new one for it?

@palisadoes
Copy link
Contributor Author

Follow the standard

@monkCommits
Copy link

@xoldyckk Hey could you please help me with this issue-
1 What exactly should I return as the api end point.
2 Could you give me a high level idea about how to start solving this issue.
Thankyou, that is all,

@xoldd
Copy link
Contributor

xoldd commented Jan 5, 2024

@monkCommits judging by your question it seems you aren't familiar with graphql? knowledge of graphql is a prerequisite to contribute to much of the logic within talawa-api

@monkCommits
Copy link

@xoldyckk Yeah thats true, I have experience with writing express APIs though. Can I take a few days to learn Graphql and come back to this?

@palisadoes
Copy link
Contributor Author

@monkCommits

  1. This was assigned to you 9 days ago and there has been no PR with suitable code. Our policy is to reassign issues with no activity after 10 days. Waiting a few more days will only delay the completion of this issue which is a dependency on new screen issues we are about to create.
  2. Please become familiar with graphQL and try to get assigned at that time. There will be many more API feature issues that will be created.

Unassigning

@AdityaRaimec22
Copy link
Contributor

AdityaRaimec22 commented Jan 6, 2024

@palisadoes can I get assigned to this issue. I know graphql very well.

@shreyashidabral
Copy link

@palisadoes Can I work on this issue

@Tarunmeena0901
Copy link

i had worked with graphql before, may be I can work on this issue ........ if u allow me to take 3rd issue (my other two are in review )
@palisadoes

@Anubhav-2003
Copy link
Contributor

@palisadoes Can I work on this issue. I know GraphQL, and only have one issue assigned, which is also almost complete. Also I intend to work on improvising the static file handeling of the API. So being able to work and familiarize myself with the grpahQL schema would help me immensenly in future issues that would involve the schema,.

@palisadoes
Copy link
Contributor Author

@Anubhav-2003

I made a error in my assessment as I was using the Git mobile app. I've assigned the issue to @AdityaRaimec22

@palisadoes
Copy link
Contributor Author

@AdityaRaimec22
@shreyashidabral

I previously made the comment which was incorrect.

You have no commit history in your profile and this issue needs someone either with GraphQL knowledge or a proven interest in coding.

I was using my Git mobile app which didn't allow me to see your extensive git contributions. I apologize for the statement. It was unfounded.

@Anubhav-2003
Copy link
Contributor

@palisadoes no problem sir.

@AdityaRaimec22
Copy link
Contributor

@palisadoes don't unassign me from this issue. I am working on it, I have written all the code just some api testing and error solving is remaining. I will create the PR very soon I was a bit busy in my academic work

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 27, 2024
@AdityaRaimec22
Copy link
Contributor

@palisadoes can you please guide me in what can be the possible reason beyond the issue that I am facing. The issue I am facing after taking a pull from the develop branch. I don't have any clue how this error originated

[1] [SUCCESS] Generate outputs
[1]   ℹ Watching for changes...
[0] d:\Desktop\talawa-api\src\directives\directiveTransformer\authDirectiveTransformer.ts:19
[0]         const { resolve = defaultFieldResolver } = fieldConfig;
[0]                           ^
[0]
[0]
[0] ReferenceError: defaultFieldResolver is not defined
[0]     at MapperKind.OBJECT_FIELD (d:\Desktop\talawa-api\src\directives\directiveTransformer\authDirectiveTransformer.ts:19:27)
[0]     at mapFields (d:\Desktop\talawa-api\node_modules\@graphql-tools\utils\cjs\mapSchema.js:146:37)      
[0]     at mapSchema (d:\Desktop\talawa-api\node_modules\@graphql-tools\utils\cjs\mapSchema.js:10:37)       
[0]     at authDirectiveTransformer (d:\Desktop\talawa-api\src\directives\directiveTransformer\authDirectiveTransformer.ts:7:10)
[0]     at loadPlugins (d:\Desktop\talawa-api\src\index.ts:34:10)
[0]     at Object.<anonymous> (d:\Desktop\talawa-api\src\index.ts:140:13)
[0]     at Module._compile (node:internal/modules/cjs/loader:1256:14)
[0]     at Object.j (D:\Desktop\talawa-api\node_modules\tsx\dist\cjs\index.cjs:1:1197)
[0]     at Module.load (node:internal/modules/cjs/loader:1119:32)
[0]     at Module._load (node:internal/modules/cjs/loader:960:12)
[0]     at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:169:29)
[0]     at ModuleJob.run (node:internal/modules/esm/module_job:194:25)
[0]
[0] Node.js v18.17.0

@Cioppolo14
Copy link
Contributor

@AdityaRaimec22 Have you verified the version of Node.js you are using? It should be 20.

@palisadoes palisadoes reopened this Feb 3, 2024
@palisadoes
Copy link
Contributor Author

palisadoes commented Feb 3, 2024

@AdityaRaimec22

You bypassed the lint rules some how and now everyone else is having linting issues. Please resubmit your changes with the correct linting applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants