Feat: PR(1) added centralized helper function for minio-upload using pre-signed url #3762
Conversation
WalkthroughThis pull request introduces a new GraphQL mutation ( Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant GraphQL_API
participant MinioServer
Client->>GraphQL_API: Call createPresignedUrl (via useMinioUpload)
GraphQL_API-->>Client: Return presigned URL + file metadata
Client->>MinioServer: HTTP PUT file using presigned URL
MinioServer-->>Client: Respond with upload status
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🔇 Additional comments (3)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (7)
docs/docs/auto-docs/GraphQl/Mutations/OrganizationMutations/variables/SEND_MEMBERSHIP_REQUEST.md (2)
11-11: Clarify Mutation Functionality Relative to Variable Name.
The description now states that the mutation “removes a custom field from an organization,” which may seem inconsistent with the variable nameSEND_MEMBERSHIP_REQUEST. If this repurposing is intentional, consider adding a brief explanatory note in the documentation to clarify this behavior for future readers.
17-20: Consider Consolidating Parameter Sections.
There are two separate## Paramheaders for the two parameters. Merging them into a single section with distinct labels for each parameter (e.g., "Organization ID" and "Custom Field ID") could enhance readability and maintain consistency in the documentation style.src/utils/MinioUpload.spec.tsx (1)
157-184: Improve mock implementation for fetch failure testThe type casting for
global.fetchis unnecessarily complex and could be simplified.- ( - global.fetch as unknown as { - mockImplementationOnce: (fn: () => Promise<Response>) => void; - } - ).mockImplementationOnce(() => Promise.resolve({ ok: false } as Response)); + (global.fetch as jest.Mock).mockImplementationOnce(() => + Promise.resolve({ ok: false } as Response) + );src/utils/MinioUpload.ts (3)
11-50: Consider enhancing the MinIO upload implementationThe implementation works well but could be improved with better error handling, progress tracking, and additional headers.
Consider these enhancements:
- Add Content-Length header for more reliable uploads
- Include more descriptive error messages with original error details
- Add timeout handling for the fetch request
- Consider adding a progress tracking callback option for larger files
Example implementation for Content-Length header:
const response = await fetch(presignedUrl, { method: 'PUT', body: file, headers: { 'Content-Type': file.type, + 'Content-Length': file.size.toString(), }, });
28-30: Improve error handling for missing presigned URLError handling could be more descriptive to help diagnose issues.
if (!data || !data.createPresignedUrl) { - throw new Error('Failed to get presigned URL'); + throw new Error('Failed to get presigned URL: The server did not return the expected data'); }
42-44: Enhance error handling for upload failuresThe current error handling doesn't include any details about the failed response, making debugging difficult.
if (!response.ok) { - throw new Error('File upload failed'); + throw new Error(`File upload failed with status: ${response.status} - ${response.statusText}`); }docs/docs/auto-docs/screens/OrgSettings/OrgSettings.mocks/variables/MOCKS.md (1)
7-7: Enhanced MOCKS Constant Definition.
The updated inline type definition for theMOCKSconstant now omits thecustomFieldsByOrganizationIdvariable, streamlining the mock configuration. Please verify that all references depending on the removed field are updated accordingly. For readability and long-term maintainability, consider extracting these extensive union type definitions into a dedicated TypeScript type or interface if feasible.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (86)
docs/docs/auto-docs/GraphQl/Mutations/OrganizationMutations/variables/ADD_CUSTOM_FIELD.md(0 hunks)docs/docs/auto-docs/GraphQl/Mutations/OrganizationMutations/variables/CANCEL_MEMBERSHIP_REQUEST.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/OrganizationMutations/variables/JOIN_PUBLIC_ORGANIZATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/OrganizationMutations/variables/REMOVE_CUSTOM_FIELD.md(0 hunks)docs/docs/auto-docs/GraphQl/Mutations/OrganizationMutations/variables/SEND_MEMBERSHIP_REQUEST.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ACCEPT_ORGANIZATION_REQUEST_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADDRESS_DETAILS_FRAGMENT.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_ADMIN_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_ADVERTISEMENT_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_MEMBER_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_PLUGIN_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/BLOCK_USER_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_EVENT_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_ORGANIZATION_MEMBERSHIP_MUTATION_PG.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_ORGANIZATION_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_ORGANIZATION_MUTATION_PG.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_POST_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_ADVERTISEMENT_BY_ID.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_EVENT_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_ORGANIZATION_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_POST_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DONATE_TO_ORGANIZATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/FORGOT_PASSWORD_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/GENERATE_OTP_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/LIKE_POST.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/PRESIGNED_URL.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/RECAPTCHA_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REFRESH_TOKEN_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REGISTER_EVENT.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REJECT_ORGANIZATION_REQUEST_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REMOVE_ADMIN_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REMOVE_MEMBER_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/RESET_COMMUNITY.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REVOKE_REFRESH_TOKEN.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/SIGNUP_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UNLIKE_POST.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_ADVERTISEMENT_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_COMMUNITY_PG.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_CURRENT_USER_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_EVENT_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_INSTALL_STATUS_PLUGIN_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_ORGANIZATION_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_ORG_STATUS_PLUGIN_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_POST_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_SESSION_TIMEOUT_PG.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_USER_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_USER_PASSWORD_MUTATION.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/PlugInQueries/variables/IS_SAMPLE_ORGANIZATION_QUERY.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/PlugInQueries/variables/ORGANIZATION_CUSTOM_FIELDS.md(0 hunks)docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ADMIN_LIST.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/Queries/variables/BLOCK_PAGE_MEMBER_LIST.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/Queries/variables/GET_COMMUNITY_DATA.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/Queries/variables/GET_COMMUNITY_DATA_PG.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/Queries/variables/GET_COMMUNITY_SESSION_TIMEOUT_DATA_PG.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/Queries/variables/GET_ORGANIZATION_EVENTS.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/Queries/variables/MEMBERSHIP_REQUEST.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/Queries/variables/MEMBERS_LIST.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATIONS_MEMBER_CONNECTION_LIST.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_DONATION_CONNECTION_LIST.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_EVENT_CONNECTION_LIST.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_EVENT_LIST.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/Queries/variables/SIGNIN_QUERY.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USERS_CONNECTION_LIST.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_DETAILS.md(1 hunks)docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_ORGANIZATION_LIST.md(1 hunks)docs/docs/auto-docs/components/LeftDrawer/LeftDrawer/functions/default.md(1 hunks)docs/docs/auto-docs/components/LeftDrawer/LeftDrawer/interfaces/InterfaceLeftDrawerProps.md(1 hunks)docs/docs/auto-docs/components/OrgSettings/General/GeneralSettings/functions/default.md(1 hunks)docs/docs/auto-docs/components/OrgSettings/General/OrgProfileFieldSettings/OrgProfileFieldSettings/functions/default.md(0 hunks)docs/docs/auto-docs/components/OrgSettings/General/OrgUpdate/OrgUpdate/functions/default.md(1 hunks)docs/docs/auto-docs/screens/OrgSettings/OrgSettings.mocks/variables/MOCKS.md(1 hunks)docs/docs/auto-docs/screens/UserPortal/LeaveOrganization/LeaveOrganization/variables/userEmail.md(1 hunks)docs/docs/auto-docs/screens/UserPortal/LeaveOrganization/LeaveOrganization/variables/userId.md(1 hunks)docs/docs/auto-docs/utils/MinioUpload/functions/useMinioUpload.md(1 hunks)docs/docs/auto-docs/utils/interfaces/interfaces/InterfaceCreateVolunteerGroup.md(1 hunks)docs/docs/auto-docs/utils/interfaces/interfaces/InterfaceCustomFieldData.md(2 hunks)docs/docs/auto-docs/utils/interfaces/interfaces/InterfaceEventVolunteerInfo.md(3 hunks)docs/docs/auto-docs/utils/interfaces/interfaces/InterfaceUserEvents.md(3 hunks)docs/docs/auto-docs/utils/interfaces/interfaces/InterfaceVolunteerGroupInfo.md(4 hunks)docs/docs/auto-docs/utils/interfaces/interfaces/InterfaceVolunteerMembership.md(3 hunks)docs/docs/auto-docs/utils/interfaces/interfaces/InterfaceVolunteerRank.md(1 hunks)docs/docs/auto-docs/utils/useLocalstorage/functions/getItem.md(2 hunks)docs/docs/auto-docs/utils/useLocalstorage/functions/setItem.md(1 hunks)src/GraphQl/Mutations/mutations.ts(1 hunks)src/utils/MinioUpload.spec.tsx(1 hunks)src/utils/MinioUpload.ts(1 hunks)
💤 Files with no reviewable changes (4)
- docs/docs/auto-docs/GraphQl/Mutations/OrganizationMutations/variables/ADD_CUSTOM_FIELD.md
- docs/docs/auto-docs/GraphQl/Mutations/OrganizationMutations/variables/REMOVE_CUSTOM_FIELD.md
- docs/docs/auto-docs/GraphQl/Queries/PlugInQueries/variables/ORGANIZATION_CUSTOM_FIELDS.md
- docs/docs/auto-docs/components/OrgSettings/General/OrgProfileFieldSettings/OrgProfileFieldSettings/functions/default.md
✅ Files skipped from review due to trivial changes (71)
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_POST_MUTATION.md
- docs/docs/auto-docs/GraphQl/Queries/Queries/variables/MEMBERS_LIST.md
- docs/docs/auto-docs/utils/MinioUpload/functions/useMinioUpload.md
- docs/docs/auto-docs/components/OrgSettings/General/GeneralSettings/functions/default.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ACCEPT_ORGANIZATION_REQUEST_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/BLOCK_USER_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REMOVE_MEMBER_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_USER_PASSWORD_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/PRESIGNED_URL.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADDRESS_DETAILS_FRAGMENT.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_POST_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_EVENT_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/GENERATE_OTP_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_ORGANIZATION_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/RESET_COMMUNITY.md
- docs/docs/auto-docs/GraphQl/Mutations/OrganizationMutations/variables/CANCEL_MEMBERSHIP_REQUEST.md
- docs/docs/auto-docs/GraphQl/Queries/Queries/variables/GET_COMMUNITY_DATA_PG.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_ADVERTISEMENT_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_ADVERTISEMENT_MUTATION.md
- docs/docs/auto-docs/GraphQl/Queries/Queries/variables/MEMBERSHIP_REQUEST.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_ADMIN_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/LIKE_POST.md
- docs/docs/auto-docs/GraphQl/Queries/Queries/variables/GET_COMMUNITY_SESSION_TIMEOUT_DATA_PG.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_ORGANIZATION_MUTATION.md
- docs/docs/auto-docs/GraphQl/Queries/Queries/variables/GET_ORGANIZATION_EVENTS.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_ORGANIZATION_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REGISTER_EVENT.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_EVENT_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/RECAPTCHA_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/SIGNUP_MUTATION.md
- docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ADMIN_LIST.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_USER_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_POST_MUTATION.md
- docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_EVENT_CONNECTION_LIST.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DONATE_TO_ORGANIZATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_COMMUNITY_PG.md
- docs/docs/auto-docs/components/OrgSettings/General/OrgUpdate/OrgUpdate/functions/default.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_INSTALL_STATUS_PLUGIN_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UNLIKE_POST.md
- docs/docs/auto-docs/GraphQl/Mutations/OrganizationMutations/variables/JOIN_PUBLIC_ORGANIZATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_SESSION_TIMEOUT_PG.md
- docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USERS_CONNECTION_LIST.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_ORGANIZATION_MUTATION_PG.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_PLUGIN_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_ADVERTISEMENT_BY_ID.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_ORG_STATUS_PLUGIN_MUTATION.md
- docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_ORGANIZATION_LIST.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REVOKE_REFRESH_TOKEN.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_EVENT_MUTATION.md
- docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_EVENT_LIST.md
- docs/docs/auto-docs/GraphQl/Queries/Queries/variables/SIGNIN_QUERY.md
- docs/docs/auto-docs/GraphQl/Queries/Queries/variables/BLOCK_PAGE_MEMBER_LIST.md
- docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_DONATION_CONNECTION_LIST.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_CURRENT_USER_MUTATION.md
- docs/docs/auto-docs/GraphQl/Queries/Queries/variables/GET_COMMUNITY_DATA.md
- docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATIONS_MEMBER_CONNECTION_LIST.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REMOVE_ADMIN_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_ORGANIZATION_MEMBERSHIP_MUTATION_PG.md
- docs/docs/auto-docs/utils/interfaces/interfaces/InterfaceUserEvents.md
- docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_DETAILS.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_MEMBER_MUTATION.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/FORGOT_PASSWORD_MUTATION.md
- docs/docs/auto-docs/components/LeftDrawer/LeftDrawer/interfaces/InterfaceLeftDrawerProps.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REFRESH_TOKEN_MUTATION.md
- docs/docs/auto-docs/utils/interfaces/interfaces/InterfaceCreateVolunteerGroup.md
- docs/docs/auto-docs/utils/interfaces/interfaces/InterfaceVolunteerRank.md
- docs/docs/auto-docs/utils/interfaces/interfaces/InterfaceEventVolunteerInfo.md
- docs/docs/auto-docs/utils/interfaces/interfaces/InterfaceVolunteerGroupInfo.md
- docs/docs/auto-docs/GraphQl/Queries/PlugInQueries/variables/IS_SAMPLE_ORGANIZATION_QUERY.md
- docs/docs/auto-docs/utils/interfaces/interfaces/InterfaceVolunteerMembership.md
- docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REJECT_ORGANIZATION_REQUEST_MUTATION.md
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test Application
🔇 Additional comments (19)
docs/docs/auto-docs/GraphQl/Mutations/OrganizationMutations/variables/SEND_MEMBERSHIP_REQUEST.md (3)
9-10: Verify the Updated Source Link.
The new definition location link now points tosrc/GraphQl/Mutations/OrganizationMutations.ts:241. Please confirm that this is the correct and intended source location for the mutation definition.
13-16: Clear Documentation of the Organization ID Parameter.
The parameter section clearly indicates that the ID of the organization (from which the custom field is to be removed) is required. This update improves clarity in the documentation.
21-23: Clear Return Value Description.
The return section succinctly explains that the mutation returns the removed organization custom field object, which is clear and sufficiently descriptive.docs/docs/auto-docs/screens/UserPortal/LeaveOrganization/LeaveOrganization/variables/userId.md (1)
7-7: Enhanced Type Safety foruserIdChanging the type from
anytounknownimproves type safety and clearly communicates the restricted usage of this variable.docs/docs/auto-docs/screens/UserPortal/LeaveOrganization/LeaveOrganization/variables/userEmail.md (1)
7-7: Enhanced Type Safety foruserEmailUpdating the type from
anytounknownincreases precision and consistency with other related documentation changes.docs/docs/auto-docs/utils/useLocalstorage/functions/setItem.md (1)
29-31: Refined Parameter Type forvalueinsetItemDocumentationChanging the parameter type from
anytounknownclarifies that explicit type handling is expected before usage, thereby improving overall type safety.docs/docs/auto-docs/utils/useLocalstorage/functions/getItem.md (2)
7-17: Introduce Generic Type Parameter ingetItemFunctionUpdating the function signature to include a generic
<T>enhances type safety by allowing callers to specify the expected type of the stored value. The addition of a dedicated "Type Parameters" section further clarifies this usage.
31-33: Clarify Return Type Description ingetItemUpdating the return documentation to state that the stored value is parsed as type
T(or null) reinforces type correctness and informs proper utilization of the function.docs/docs/auto-docs/components/LeftDrawer/LeftDrawer/functions/default.md (3)
7-11: Refactor Function Signature fordefaultComponentChanging the signature to use
propsinstead of the generic__namedParametersaligns the documentation with best practices for React components and improves readability.
15-19: Clarify Documentation for Component PropsUsing the
[InterfaceLeftDrawerProps](../interfaces/InterfaceLeftDrawerProps.md)link along with a clear description forpropsimproves understanding of the expected inputs for the component.
25-25: Update Return DescriptionThe revised return description "The rendered LeftDrawer component" succinctly communicates the expected output of the function.
docs/docs/auto-docs/utils/interfaces/interfaces/InterfaceCustomFieldData.md (3)
11-15: LGTM: AddedidpropertyThe new optional
idproperty is correctly documented with proper formatting and reference to the implementation file.
27-33: LGTM: AddedorganizationIdpropertyThe new optional
organizationIdproperty is correctly documented with proper formatting and reference to the implementation file.
39-39: LGTM: Updated reference fortypepropertyThe reference line for the
typeproperty has been correctly updated to point to line 1279.src/utils/MinioUpload.spec.tsx (3)
8-40: LGTM: Well-structured TestComponent for testing useMinioUpload hookThe TestComponent is well-implemented with proper state management and error handling. It correctly uses the hook and provides appropriate feedback through status updates.
42-110: LGTM: Comprehensive test for successful file uploadThis test thoroughly checks the successful upload flow, including:
- Initial status updates
- Proper mock setup
- Verification of the onUploadComplete callback with correct data
The test setup with MockedProvider and file mocking is well-executed.
112-155: LGTM: Proper error testing for mutation failureThe test correctly verifies error handling when the GraphQL mutation returns null data.
src/utils/MinioUpload.ts (1)
4-9: LGTM: Clean interface definitionThe
InterfaceMinioUploadinterface clearly defines the contract with appropriate types and return values.docs/docs/auto-docs/screens/OrgSettings/OrgSettings.mocks/variables/MOCKS.md (1)
9-9: Source Reference Link Confirmation.
The documentation now includes a clear reference to the source file (src/screens/OrgSettings/OrgSettings.mocks.ts:8), which improves traceability. This update is consistent with the change in the mock definition and aids future maintenance.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #3762 +/- ##
====================================================
+ Coverage 86.06% 86.09% +0.03%
====================================================
Files 372 373 +1
Lines 9219 9232 +13
Branches 1951 1953 +2
====================================================
+ Hits 7934 7948 +14
Misses 903 903
+ Partials 382 381 -1 ☔ View full report in Codecov by Sentry. |
|
@palisadoes please review . Now others can start working on this The biggest drawback is the issue regarding the |
|
@noman2002 @beingnoble03 Can you review this PR? |
|
Please fix the conflicting files |
On it |
|
https://docs.google.com/document/d/18nFPcaui_jEdYUq_mJ06mcJos7rglwFpG_irggeTj6Y/edit?tab=t.0 Architecture for direct upload from frontend using |
palisadoes
merged commit 9eeb840
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
Issue Number: #3729
Fixes #
Snapshots/Videos:
N/A
If relevant, did you update the documentation?
Summary
1-st PR of the series of minio-client PRs
created a helper function that will get the presigned url from backend and it will
PUTthefiles in the minio-server
Does this PR introduce a breaking change?
Checklist
CodeRabbit AI Review
Test Coverage
Other information
Have you read the contributing guide?
Summary by CodeRabbit
New Features
Documentation