-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix User Role in People Section #2459
Open
aditya-bansal-7
wants to merge
16
commits into
PalisadoesFoundation:develop-postgres
Choose a base branch
from
aditya-bansal-7:fix-user-role-in-people-section
base: develop-postgres
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
97b380a
Fix User Role in People Section
aditya-bansal-7 f19cf8b
fix : formating
aditya-bansal-7 90e6e02
resolve : types errors
aditya-bansal-7 2973b7a
Merge branch 'develop-postgres' into fix-user-role-in-people-section
aditya-bansal-7 2236632
Make changes as suggested
aditya-bansal-7 1d8069a
Make changes as suggested
aditya-bansal-7 a2eb1c2
Make changes suggested by code rabbit
aditya-bansal-7 9b6cf5a
Added test case
aditya-bansal-7 c1b6e3a
Fix format
aditya-bansal-7 f26b9e5
Fix test for userType check
aditya-bansal-7 d9ae4d0
Again Fix error
aditya-bansal-7 f7ccfb5
Merge branch 'develop-postgres' into fix-user-role-in-people-section
aditya-bansal-7 943eebe
removed error by test case
aditya-bansal-7 a5191df
Merge branch 'develop-postgres' into fix-user-role-in-people-section
aditya-bansal-7 4982b1f
Update People.test.tsx
aditya-bansal-7 25beeb6
Merge branch
aditya-bansal-7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Strengthen test assertions
The current assertions using
queryByText
are too broad and may pass even if roles appear in unintended locations.Consider:
Example structure: