Added features to filter chats, edit messages, add users to group chat, share images as messages, and create dedicated group chats for events #2360
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -396,7 +396,8 @@ | |
| "on": "En", | ||
| "after": "Después de", | ||
| "occurences": "ocurrencias", | ||
| "done": "Hecho", | ||
| "createChat": "Crear chat" | ||
| }, | ||
| "organizationActionItems": { | ||
| "actionItemCategory": "Categoría del ítem de acción", | ||
|
|
@@ -531,7 +532,8 @@ | |
| "on": "En", | ||
| "after": "Después de", | ||
| "occurences": "ocurrencias", | ||
| "done": "Hecho", | ||
| "createChat": "Crear chat" | ||
| }, | ||
| "funds": { | ||
| "title": "Fondos", | ||
|
|
@@ -1116,7 +1118,8 @@ | |
| "publicEvent": "Es público", | ||
| "registerable": "Es registrable", | ||
| "monthlyCalendarView": "Calendario mensual", | ||
| "yearlyCalendarView": "Calendario anual", | ||
| "createChat": "Crear chat" | ||
| }, | ||
| "userEventCard": { | ||
| "location": "Ubicación", | ||
|
|
@@ -1160,14 +1163,21 @@ | |
| "createAdvertisement": "Crear publicidad" | ||
| }, | ||
| "userChat": { | ||
| "add": "Agregar", | ||
| "chat": "Charlar", | ||
| "search": "Buscar", | ||
| "contacts": "Contactos", | ||
| "messages": "Mensajes", | ||
| "create": "crear", | ||
| "newChat": "nueva charla", | ||
| "newGroupChat": "Nuevo chat grupal", | ||
| "groupInfo": "Información del grupo", | ||
| "members": "Miembros" | ||
| }, | ||
| "userChatRoom": { | ||
| "selectContact": "Seleccione un contacto para iniciar una conversación", | ||
| "sendMessage": "Enviar mensaje", | ||
| "reply": "responder" | ||
| }, | ||
| "orgProfileField": { | ||
| "loading": "Cargando..", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -396,7 +396,8 @@ | |
| "startDate": "开始日期", | ||
| "endDate": "结束日期", | ||
| "talawaApiUnavailable": "塔拉瓦 API 不可用", | ||
| "done": "完成", | ||
| "createChat": "创建聊天" | ||
|
Comment on lines
+426
to
+427
There was a problem hiding this comment. Consolidate redundant "createChat" translations. The translation key Apply this diff: "organizationEvents": {
"done": "完成",
- "createChat": "创建聊天"
},
"eventListCard": {
"done": "完成",
- "createChat": "创建聊天"
},
"userEvents": {
"endDate": "结束日期",
- "createChat": "创建聊天"
},
"userChat": {
"add": "添加",
"chat": "聊天",
...
+ "createChat": "创建聊天"
}Also applies to: 562-563, 1147-1148 |
||
| }, | ||
| "organizationActionItems": { | ||
| "actionItemCategory": "行动项目类别", | ||
|
|
@@ -531,7 +532,8 @@ | |
| "registerEvent": "注册活动", | ||
| "close": "关闭", | ||
| "talawaApiUnavailable": "塔拉瓦 API 不可用", | ||
| "done": "完成", | ||
| "createChat": "创建聊天" | ||
| }, | ||
| "funds": { | ||
| "title": "基金", | ||
|
|
@@ -1115,7 +1117,8 @@ | |
| "eventDescription": "活动描述", | ||
| "eventLocation": "活动位置", | ||
| "startDate": "开始日期", | ||
| "endDate": "结束日期", | ||
| "createChat": "创建聊天" | ||
| }, | ||
| "userEventCard": { | ||
| "starts": "开始", | ||
|
|
@@ -1159,14 +1162,21 @@ | |
| "endOfResults": "结果结束" | ||
| }, | ||
| "userChat": { | ||
| "add": "添加", | ||
| "chat": "聊天", | ||
| "contacts": "联系方式", | ||
| "search": "搜索", | ||
| "messages": "消息", | ||
| "create": "创造", | ||
| "newChat": "新聊天", | ||
| "newGroupChat": "新群聊", | ||
| "groupInfo": "集团信息", | ||
| "members": "会员" | ||
|
There was a problem hiding this comment. Add missing translations for core chat features. While basic chat translations are present, translations for several key features mentioned in the PR objectives are missing:
Add the following translations: "userChat": {
"add": "添加",
"chat": "聊天",
"contacts": "联系方式",
"search": "搜索",
"messages": "消息",
"create": "创造",
"newChat": "新聊天",
"newGroupChat": "新群聊",
"groupInfo": "集团信息",
"members": "会员",
+ "filterChats": "筛选聊天",
+ "editMessage": "编辑消息",
+ "shareImage": "分享图片"
}
|
||
| }, | ||
| "userChatRoom": { | ||
| "selectContact": "选择联系人开始对话", | ||
| "sendMessage": "发信息", | ||
| "reply": "回复" | ||
| }, | ||
| "orgProfileField": { | ||
| "loading": "加载中...", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -555,7 +555,6 @@ type ChatMessage { | |
| createdAt: DateTime! | ||
| chatMessageBelongsTo: Chat! | ||
| messageContent: String! | ||
| replyTo: ChatMessage | ||
| sender: User! | ||
| deletedBy: [User] | ||
|
|
@@ -692,7 +691,6 @@ type Mutation { | |
| createAgendaCategory(input: CreateAgendaCategoryInput!): AgendaCategory! | ||
| createComment(data: CommentInput!, postId: ID!): Comment | ||
| createChat(data: chatInput!): Chat! | ||
| createDonation( | ||
| amount: Float! | ||
| nameOfOrg: String! | ||
|
|
@@ -706,7 +704,6 @@ type Mutation { | |
| recurrenceRuleData: RecurrenceRuleInput | ||
| ): Event! | ||
| createEventVolunteer(data: EventVolunteerInput!): EventVolunteer! | ||
| createMember(input: UserAndOrganizationInput!): Organization! | ||
| createMessageChat(data: MessageChatInput!): MessageChat! | ||
| createOrganization(data: OrganizationInput, file: String): Organization! | ||
|
|
@@ -766,15 +763,8 @@ type Mutation { | |
| revokeRefreshTokenForUser: Boolean! | ||
| saveFcmToken(token: String): Boolean! | ||
| sendMembershipRequest(organizationId: ID!): MembershipRequest! | ||
| sendMessageToChat(chatId: ID!, messageContent: String!, replyTo: ID): ChatMessage! | ||
| markChatMessagesAsRead(chatId: ID!, userId: ID!): Chat | ||
|
Comment on lines
+766
to
+767
There was a problem hiding this comment. 🛠️ Refactor suggestion Consider enhancing markChatMessagesAsRead mutation. The mutation could be improved by:
Consider this alternative design: type MarkChatMessagesAsReadPayload {
chat: Chat!
markedMessagesCount: Int!
}
extend type Mutation {
markChatMessagesAsRead(input: MarkChatMessagesAsReadInput!): MarkChatMessagesAsReadPayload!
}
input MarkChatMessagesAsReadInput {
chatId: ID!
userId: ID!
"""
Optional: Mark messages as read up to this message ID
If not provided, marks all messages as read
"""
upToMessageId: ID
} |
||
| signUp(data: UserInput!, file: String): AuthData! | ||
| togglePostPin(id: ID!, title: String): Post! | ||
| unassignUserTag(input: ToggleUserTagAssignInput!): User | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -186,13 +186,14 @@ function app(): JSX.Element { | |
| <Route element={<SecuredRouteForUser />}> | ||
| <Route path="/user/organizations" element={<Organizations />} /> | ||
| <Route path="/user/settings" element={<Settings />} /> | ||
| {/* <Route path="/user/chat" element={<Chat />} /> */} | ||
| <Route element={<UserScreen />}> | ||
| <Route path="/user/organizations" element={<Organizations />} /> | ||
| <Route path="/user/organization/:orgId" element={<Posts />} /> | ||
| <Route path="/user/people/:orgId" element={<People />} /> | ||
| <Route path="/user/donate/:orgId" element={<Donate />} /> | ||
| <Route path="/user/events/:orgId" element={<Events />} /> | ||
| <Route path="/user/chat/:orgId" element={<Chat />} /> | ||
| <Route path="/user/campaigns/:orgId" element={<Campaigns />} /> | ||
| <Route path="/user/pledges/:orgId" element={<Pledges />} /> | ||
| <Route element={<EventDashboardScreen />}> | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translations for message editing.
While "reply" functionality is supported, the translations don't include strings for editing messages, which was mentioned in the PR objectives.
Add the following translation keys:
"userChatRoom": { "selectContact": "Select a contact to start conversation", "sendMessage": "Send Message", "reply": "Reply", + "editMessage": "Edit message", + "saveEdit": "Save changes", + "cancelEdit": "Cancel edit" }