Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Navbar with appropriate Logo #2287

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

syedali237
Copy link

@syedali237 syedali237 commented Sep 22, 2024

What kind of change does this PR introduce?

Bugfix

Issue Number:

Fixes #1923

Did you add tests for your changes?

No

Snapshots/Videos:

Screenshot 2024-09-23 at 2 32 11 AM

If relevant, did you update the documentation?

No

Summary

This PR updates the logo in the Navbar. This change improves the visual consistency of the application and addresses the logo issue.

Does this PR introduce a breaking change?

No

Other information

N/A

Have you read the contributing guide?

Yes

Summary by CodeRabbit

  • New Features

    • Updated logo images across various components to a higher resolution (600x600 pixels) for improved visual quality.
      • Organization Navbar
      • User Navbar
      • Page Not Found screen
  • Bug Fixes

    • None
  • Documentation

    • None
  • Refactor

    • None
  • Style

    • Improved image quality for better user experience.
  • Tests

    • None
  • Chores

    • None
  • Revert

    • None

Copy link

coderabbitai bot commented Sep 22, 2024

Walkthrough

The pull request includes updates to the image assets used in the OrganizationNavbar, UserNavbar, and PageNotFound components. Each component's logo has been changed from a smaller 200x200 pixel version to a larger 600x600 pixel version. These modifications enhance the visual representation of the logos across the application without affecting the underlying functionality of the components.

Changes

Files Change Summary
src/components/UserPortal/OrganizationNavbar/OrganizationNavbar.tsx
src/components/UserPortal/UserNavbar/UserNavbar.tsx
src/screens/PageNotFound/PageNotFound.tsx
Updated import statements for the Talawa logo image from talawa-logo-200x200.png to talawa-logo-600x600.png.

Assessment against linked issues

Objective Addressed Explanation
Use an appropriate image from our official logo repo (#1923)
Delete the offending image from this repo (#1923) No deletion of the old image was performed.

🐇 In the world of code, a change so bright,
A logo reborn, now a glorious sight!
From small to grand, it takes its place,
In every navbar, it’s full of grace.
Hopping through pixels, a joyful cheer,
Talawa shines bright, let’s give a cheer! 🎉


Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 01ef5c6 and 0ea8ef8.

Files ignored due to path filters (2)
  • src/assets/images/talawa-logo-200x200.png is excluded by !**/*.png
  • src/assets/images/talawa-logo-600x600.png is excluded by !**/*.png
Files selected for processing (3)
  • src/components/UserPortal/OrganizationNavbar/OrganizationNavbar.tsx (1 hunks)
  • src/components/UserPortal/UserNavbar/UserNavbar.tsx (1 hunks)
  • src/screens/PageNotFound/PageNotFound.tsx (1 hunks)
Files skipped from review due to trivial changes (3)
  • src/components/UserPortal/OrganizationNavbar/OrganizationNavbar.tsx
  • src/components/UserPortal/UserNavbar/UserNavbar.tsx
  • src/screens/PageNotFound/PageNotFound.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (01ef5c6) to head (0ea8ef8).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2287   +/-   ##
========================================
  Coverage    97.54%   97.54%           
========================================
  Files          241      241           
  Lines         6887     6887           
  Branches      2016     2005   -11     
========================================
  Hits          6718     6718           
  Misses         157      157           
  Partials        12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes palisadoes merged commit 959399d into PalisadoesFoundation:develop Sep 23, 2024
12 checks passed
@syedali237 syedali237 deleted the 1923 branch September 29, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants