upgraded testing-lib/user-event to 14.5.2 #2266
Conversation
WalkthroughThis pull request updates the Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Poem
Tip OpenAI O1 model for chat
Recent review detailsConfiguration used: .coderabbit.yaml Files ignored due to path filters (1)
Files selected for processing (20)
Files skipped from review due to trivial changes (18)
Additional comments not posted (10)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Please fix the failing test |
|
@palisadoes I am on it, but can you please assign this issue to me, as I requested earlier in issue #2072 |
|
Assigned it. Make sure to first get assigned and then only raise PRs from next time. |
|
@pranshugupta54 Thank you. |
|
@palisadoes Please do not close this PR, as I've resolved most of the testcases since. Now I 'm only left with 6. |
|
This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
|
Closing. Inactivity |
What kind of change does this PR introduce?
Dependency upgrade and refactoring
Issue Number:
Fixes #2072
Did you add tests for your changes?
No
Snapshots/Videos:
N/A
If relevant, did you update the documentation?
N/A
Summary
This PR addresses the dependency upgrade of @testing-library/user-event from 12.8.3 to 14.5.2.
Rationale: This upgrade was attempted by the automated dependabot job previously, but the PR tests failed.
This PR resolves multiple dependency issues, ensuring compatibility and preventing further build failures.
Additionally, it examines if this package is:
Unused or unnecessary (i.e., whether similar functionality can be provided by other existing packages or if it’s used in minor functionalities that the end user may not utilize).
After reviewing, it was determined that the package is necessary for certain testing functionalities.
Does this PR introduce a breaking change?
No
Other information
This PR resolves the dependency issue causing tests to fail in previous upgrade attempts.
Background failing PRs:
chore(deps): bump @testing-library/user-event from 12.8.3 to 14.5.2 #2065.
Have you read the contributing guide?
Yes
Summary by CodeRabbit
New Features
@testing-library/user-eventpackage to enhance testing capabilities.Bug Fixes
toBeCalledWithwithtoHaveBeenCalledWith.Chores