Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated and optimized Home.test.tsx #1147

Closed
wants to merge 2 commits into from
Closed

Updated and optimized Home.test.tsx #1147

wants to merge 2 commits into from

Conversation

vivekBoii
Copy link

What kind of change does this PR introduce?

Update and optimization of code

Issue Number:

Fixes #1131

Did you add tests for your changes?

This is unittest itself

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Update and optimization of code in Home.test.tsx

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

Yes

Copy link

github-actions bot commented Dec 6, 2023

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@vivekBoii vivekBoii changed the title optimized Home.test.tsx Updated and optimized Home.test.tsx Dec 6, 2023
Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the linting errors.

@vivekBoii
Copy link
Author

@noman2002 thank you sir for pointing me out , I will not repeat it next time

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c6d8f4) 94.49% compared to head (c5a79eb) 94.49%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1147   +/-   ##
========================================
  Coverage    94.49%   94.49%           
========================================
  Files          138      138           
  Lines         3286     3286           
  Branches       912      912           
========================================
  Hits          3105     3105           
  Misses         174      174           
  Partials         7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes
Copy link
Contributor

palisadoes commented Dec 7, 2023

Why hasn't the code coverage increased in this PR? The issue was created to increase it to 100%. Please let us know.

@palisadoes
Copy link
Contributor

The test code coverage is dropping significantly with this PR. Please get to at least 95% coverage for all your edited files. Though there may be issues to increase the coverage for the file, the aim is for them to reach 100% coverage

Please post the screenshot with your coverage when complete

@palisadoes
Copy link
Contributor

@vivekBoii are you still working on this?

@Cioppolo14
Copy link

I am closing this as there hasn't been any activity in 3 weeks.

@Cioppolo14 Cioppolo14 closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants