Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a list of users for pagerduty_team #346

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TomTucka
Copy link
Contributor

@TomTucka TomTucka commented Jun 11, 2021

Addresses #345. Still WIP, Need to figure out tests for this 👍🏼

@stmcallister
Copy link
Contributor

I like where you're going with this! Once you get some tests figured out and implemented I'd be happy to review!

@jbfavre
Copy link
Contributor

jbfavre commented Jul 29, 2021

I second this PR, because it could help to manage user_notifications using Terraform, without having the need to manage users
It could be the opportunity to enforce users' notifications rules at team level.

However, I also see a possible issue with the logic exposed in #345 : when creating a new layer using the Web UI, and depending on start date, users' will be sorted out by PagerDuty API to keep the schedule order consistent.
So, how to sort team members list to be usable in a layer configuration ?
I don't see any elegant way to automatically reconciliate Terraform and the API. 🤔
WDYT @stmcallister ?

@rmgpinto
Copy link

I was looking for something like this to have Pager Duty be our source of truth for alerting teams.
As @jbfavre said, it would be nice to have terraform know all team members, but not necessarily manage them.

@doryer
Copy link

doryer commented May 9, 2022

Looking forward for this to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants