Fix Receiver Port Detection in the Septentrio Driver #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port detection would often find incorrect ports like '%és<' or other broken values. This solves that by limiting the ports to a predefined set of values. For now those are only COM and USB ports, as those are the most likely to be used with PX4 autopilot and QGroundControl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue which can prevent PX4 autopilot from recognizing the receiver port, sometimes leading to a failure to configure the driver or long attempts before it finally works. The current official release of PX4 autopilot is impacted by this issue. Currently work is being done on a new driver for Septentrio which would live in-tree (PX4/PX4-Autopilot#22904), so I'm making this one against the release branch only. If it needs to go in the main branch as well, I can also make a pull request for that.