Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for more flexible microdata inputs #202

Merged
merged 19 commits into from
Jun 10, 2024

Conversation

jdebacker
Copy link
Member

This PR adds functionality to make it straightforward for users to use the CPS, PUF, and TMD files that Tax-Calculator is compatible with. It also preserves the ability to include a custom data file, but adds arguments to pass custom grow factors and weights with the data.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

Attention: Patch coverage is 35.37415% with 95 lines in your changes missing coverage. Please review.

Project coverage is 79.50%. Comparing base (8b9fba3) to head (782931e).

Files Patch % Lines
taxbrain/taxbrain.py 31.70% 56 Missing ⚠️
cs-config/cs_config/helpers.py 11.11% 16 Missing ⚠️
cs-config/cs_config/functions.py 25.00% 15 Missing ⚠️
taxbrain/tests/test_brain.py 70.83% 7 Missing ⚠️
setup.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   83.13%   79.50%   -3.63%     
==========================================
  Files          23       23              
  Lines        1844     1947     +103     
==========================================
+ Hits         1533     1548      +15     
- Misses        311      399      +88     
Flag Coverage Δ
unittests 79.50% <35.37%> (-3.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdebacker
Copy link
Member Author

@andersonfrailey This PR is ready for review. I'd appreciate if you could look over my changes to the API to make sure there's nothing Tax-Brain would lose from my proposed changes.

@jdebacker jdebacker merged commit 1cd87f4 into PSLmodels:master Jun 10, 2024
8 checks passed
@jdebacker jdebacker deleted the flex_data branch June 10, 2024 19:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants