Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing conductance shape from Nt by 1 to Nt by 2 for ALL conductance models #2849

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

mkaguer
Copy link
Contributor

@mkaguer mkaguer commented Oct 26, 2023

Fixes #2843

@mkaguer mkaguer changed the title Issue2843 g shape Changing conductance shape from Nt by 1 to Nt by 2 for ALL conductance models Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2849 (e2ec2b0) into dev (daff76f) will decrease coverage by 0.1%.
Report is 5 commits behind head on dev.
The diff coverage is 91.6%.

Additional details and impacted files
@@           Coverage Diff           @@
##             dev   #2849     +/-   ##
=======================================
- Coverage   89.8%   89.8%   -0.1%     
=======================================
  Files        148     148             
  Lines       8615    8631     +16     
=======================================
+ Hits        7744    7753      +9     
- Misses       871     878      +7     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug when mixing symmetric and asymmetric conductance in different domains
1 participant