-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cbf): support crabs as a representative control barrier function based algorithm #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
- Coverage 96.59% 96.57% -0.01%
==========================================
Files 139 139
Lines 7090 7089 -1
==========================================
- Hits 6848 6846 -2
- Misses 242 243 +1 ☔ View full report in Codecov by Sentry. |
Gaiejj
previously approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Gaiejj
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat(cbf): support crabs as a representative control barrier function based algorithm.
We are delighted to have implemented the CRABS(NeurIPS 2021) algorithm, a representative control barrier function based method, and compared it with the original implementation. During the implementation process, we carefully compared the implementation details to ensure that the gradient flow was completely consistent with the code provided by the authors. Our results achieved similar performance, and we hope this contribution will facilitate easier comparisons with CBF-based methods within the SafeRL community, while also leveraging our tool for enhanced research.
However, we observed that this algorithm requires the use of pretrained model parameters as a starting point for training, and it is currently unclear how these parameters are obtained. This issue was also mentioned in the Paper Decision that decide to accept this paper. Fortunately, the authors provided pretrained model parameters for the
Swing
environment, which allowed us to successfully replicate part of the performance.Here is the performance of the original paper:
Here is the performance from our implementation:
Regarding the remaining environments:
Move
,Upright
, andTilt
, we are actively communicating with the authors. If the community has any solutions to this issue and is willing to support us, please feel free to contact us. Your support is crucial to our progress.Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213
if this solves the issue #15213Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format
. (required)make lint
. (required)make test
pass. (required)